Bump spotless to 8.0.0#18770
Conversation
246ec7e to
3c3d1c9
Compare
removeWildcardImports
removeWildcardImportsremoveWildcardImports
removeWildcardImportsremoveWildcardImports
3c3d1c9 to
2ea7836
Compare
|
❌ Gradle check result for 2ea7836: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
2ea7836 to
965ef23
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
closing due to conflicts. Need to merge this close by due to the nature of format. Its trivial anyways. The actual cause here is to check why CI is failing to bump this. |
|
assuming ready to go: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #18770 +/- ##
=======================================
Coverage ? 73.17%
Complexity ? 71191
=======================================
Files ? 5766
Lines ? 325467
Branches ? 47084
=======================================
Hits ? 238152
Misses ? 68162
Partials ? 19153 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@Pankraz76 Were we waiting on diffplug/spotless#2571 which I see is part of 8.0 release. Probably good to upgrade spotless to 8.0 now? |
f95f1d9 to
21d39d7
Compare
21d39d7 to
19c1a12
Compare
Thanks for catching up on this as well, together we can automate and improve this codebase sustaniable. |
|
❌ Gradle check result for 19c1a12: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
might be IO: |
Signed-off-by: Vincent Potucek <vpotucek@me.com>
19c1a12 to
e137f0a
Compare
|
rebase |
|
❌ Gradle check result for e137f0a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Seems like intermittent as it succeeded on my machine with this change checked out. Re-running |
[Describe what this change achieves]
while experimenting with rewrite i came across this custom solution for what recently has been integrated into spot.
removeWildcardImports()diffplug/spotless#2526could not do it without @iddeepak, thanks for the decent impl.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.