Skip to content

Bump spotless to 8.0.0#18770

Merged
sandeshkr419 merged 1 commit intoopensearch-project:mainfrom
Pankraz76:use-removeWildcardImports
Nov 4, 2025
Merged

Bump spotless to 8.0.0#18770
sandeshkr419 merged 1 commit intoopensearch-project:mainfrom
Pankraz76:use-removeWildcardImports

Conversation

@Pankraz76
Copy link
Copy Markdown
Contributor

@Pankraz76 Pankraz76 commented Jul 16, 2025

[Describe what this change achieves]

while experimenting with rewrite i came across this custom solution for what recently has been integrated into spot.

could not do it without @iddeepak, thanks for the decent impl.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Pankraz76 Pankraz76 requested a review from a team as a code owner July 16, 2025 15:11
@Pankraz76 Pankraz76 force-pushed the use-removeWildcardImports branch from 246ec7e to 3c3d1c9 Compare July 16, 2025 15:12
@Pankraz76 Pankraz76 changed the title use spotless removeWildcardImports for custom implementation use spotless instead of custom implementation for removeWildcardImports Jul 16, 2025
@Pankraz76 Pankraz76 changed the title use spotless instead of custom implementation for removeWildcardImports use spotless implementation of removeWildcardImports Jul 16, 2025
@Pankraz76 Pankraz76 changed the title use spotless implementation of removeWildcardImports Fix spotless implementation of removeWildcardImports Jul 16, 2025
@Pankraz76 Pankraz76 force-pushed the use-removeWildcardImports branch from 3c3d1c9 to 2ea7836 Compare July 16, 2025 15:23
@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 2ea7836: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@Pankraz76

This comment was marked as resolved.

@Pankraz76
Copy link
Copy Markdown
Contributor Author

closing due to conflicts. Need to merge this close by due to the nature of format.

Its trivial anyways. The actual cause here is to check why CI is failing to bump this.

@Pankraz76 Pankraz76 closed this Aug 12, 2025
@Pankraz76
Copy link
Copy Markdown
Contributor Author

@Pankraz76 Pankraz76 reopened this Oct 9, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 9, 2025

✅ Gradle check result for f95f1d9: SUCCESS

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@6b5c08a). Learn more about missing BASE report.
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18770   +/-   ##
=======================================
  Coverage        ?   73.17%           
  Complexity      ?    71191           
=======================================
  Files           ?     5766           
  Lines           ?   325467           
  Branches        ?    47084           
=======================================
  Hits            ?   238152           
  Misses          ?    68162           
  Partials        ?    19153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sandeshkr419
Copy link
Copy Markdown
Member

@Pankraz76 Were we waiting on diffplug/spotless#2571 which I see is part of 8.0 release.

Probably good to upgrade spotless to 8.0 now?

@Pankraz76 Pankraz76 changed the title Update spotless to 7.1.0 Update spotless to 8.0.0 Nov 4, 2025
@Pankraz76 Pankraz76 force-pushed the use-removeWildcardImports branch from f95f1d9 to 21d39d7 Compare November 4, 2025 10:32
@Pankraz76 Pankraz76 force-pushed the use-removeWildcardImports branch from 21d39d7 to 19c1a12 Compare November 4, 2025 10:34
@Pankraz76
Copy link
Copy Markdown
Contributor Author

@Pankraz76 Were we waiting on diffplug/spotless#2571 which I see is part of 8.0 release.

Probably good to upgrade spotless to 8.0 now?

Thanks for catching up on this as well, together we can automate and improve this codebase sustaniable.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 4, 2025

❌ Gradle check result for 19c1a12: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@Pankraz76
Copy link
Copy Markdown
Contributor Author

Pankraz76 commented Nov 4, 2025

might be IO:

  1> org.opensearch.transport.ConnectTransportException: [node_t0][127.0.0.1:38991] connect_exception

Signed-off-by: Vincent Potucek <vpotucek@me.com>
@Pankraz76 Pankraz76 changed the title Update spotless to 8.0.0 Bump spotless to 8.0.0 Nov 4, 2025
@Pankraz76 Pankraz76 force-pushed the use-removeWildcardImports branch from 19c1a12 to e137f0a Compare November 4, 2025 14:13
@Pankraz76
Copy link
Copy Markdown
Contributor Author

rebase

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 4, 2025

❌ Gradle check result for e137f0a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sandeshkr419
Copy link
Copy Markdown
Member

* What went wrong:
Execution failed for task ':modules:aggs-matrix-stats:spotlessJava'.
> Cannot fingerprint input property 'stepsInternalEquality': value 'com.diffplug.spotless.ConfigurationCacheHackList@2154da26' cannot be serialized.

Seems like intermittent as it succeeded on my machine with this change checked out. Re-running gradle check.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 4, 2025

✅ Gradle check result for e137f0a: SUCCESS

@sandeshkr419 sandeshkr419 merged commit ef35266 into opensearch-project:main Nov 4, 2025
36 of 38 checks passed
liuguoqingfz pushed a commit to liuguoqingfz/OpenSearch that referenced this pull request Dec 15, 2025
Co-authored-by: Vincent Potucek <vpotucek@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants