Skip to content

[BUG] Repository s3 plugin test S3RepositoryThirdPartyTests.java does not have an option to override path_style_access and endpoint #18796#18855

Merged
andrross merged 4 commits intoopensearch-project:mainfrom
asifabashar:s3_feature
Jul 31, 2025
Merged

[BUG] Repository s3 plugin test S3RepositoryThirdPartyTests.java does not have an option to override path_style_access and endpoint #18796#18855
andrross merged 4 commits intoopensearch-project:mainfrom
asifabashar:s3_feature

Conversation

@asifabashar
Copy link
Copy Markdown
Contributor

Issue #18796

Description

Describe the bug
[Repository s3 plugin test S3RepositoryThirdPartyTests.java does not have an option to override path_style_access and endpoint for integration tests, this helps to test for different possible s3 settings.
With the fix we will be able to test any changes with above 2 settings variations ,
Current integration test is, AWS_REGION=us-west-2 amazon_s3_access_key=$AWS_ACCESS_KEY_ID amazon_s3_secret_key=$AWS_SECRET_ACCESS_KEY amazon_s3_base_path=path amazon_s3_bucket=dblock-opensearch ./gradlew :plugins:repository-s3:s3ThirdPartyTest
With this chaange, we will also pass custom path_style_access and endpoint.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • [ x] Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ave an option to override pathStyle and endpoint

Signed-off-by: Asif Bashar <abashar@apple.com>
@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for dc6614a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

…ave an option to override pathStyle and endpoint

Signed-off-by: Asif Bashar <abashar@apple.com>
@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 9e199bb: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@asifabashar
Copy link
Copy Markdown
Contributor Author

Gradle test passed, Failure unrelated where a jdk download failed for macos

FAILURE: Build failed with an exception.

  • What went wrong:
    Execution failed for task ':distribution:archives:buildDarwinArm64Tar'.

Could not resolve all files for configuration ':distribution:archives:jdk_bundled_jdk_darwin_aarch64'.
Failed to transform mac-24.0.1-aarch64.tar.gz (adoptium_24:mac:24.0.1) to match attributes {artifactType=directory, jdk=true, org.gradle.status=integration}.
> Could not download mac-24.0.1-aarch64.tar.gz (adoptium_24:mac:24.0.1)
> Could not get resource 'https://github.com/adoptium/temurin24-binaries/releases/download/jdk-24.0.1+9/OpenJDK24U-jdk_aarch64_mac_hotspot_24.0.1_9.tar.gz'.
> Could not GET 'https://github.com/adoptium/temurin24-binaries/releases/download/jdk-24.0.1+9/OpenJDK24U-jdk_aarch64_mac_hotspot_24.0.1_9.tar.gz'. Received status code 503 from server: Service Unavailable

…ave an option to override pathStyle and endpoint

Signed-off-by: Asif Bashar <abashar@apple.com>
@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 9dd835c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

…ave an option to override pathStyle and endpoint

Signed-off-by: Asif Bashar <abashar@apple.com>
@github-actions
Copy link
Copy Markdown
Contributor

✅ Gradle check result for e89fca4: SUCCESS

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.81%. Comparing base (1f761f2) to head (e89fca4).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #18855      +/-   ##
============================================
+ Coverage     72.79%   72.81%   +0.02%     
- Complexity    68627    68635       +8     
============================================
  Files          5572     5577       +5     
  Lines        315196   315375     +179     
  Branches      45750    45772      +22     
============================================
+ Hits         229454   229655     +201     
+ Misses        67153    67078      -75     
- Partials      18589    18642      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrross andrross merged commit cff74ff into opensearch-project:main Jul 31, 2025
34 of 35 checks passed
sunqijun1 pushed a commit to sunqijun1/OpenSearch that referenced this pull request Aug 4, 2025
… not have an option to override path_style_access and endpoint opensearch-project#18796 (opensearch-project#18855)

* Repository s3 plugin test S3RepositoryThirdPartyTests.java does not have an option to override pathStyle and endpoint

Signed-off-by: Asif Bashar <abashar@apple.com>

* Repository s3 plugin test S3RepositoryThirdPartyTests.java does not have an option to override pathStyle and endpoint

Signed-off-by: Asif Bashar <abashar@apple.com>

* Repository s3 plugin test S3RepositoryThirdPartyTests.java does not have an option to override pathStyle and endpoint

Signed-off-by: Asif Bashar <abashar@apple.com>

* Repository s3 plugin test S3RepositoryThirdPartyTests.java does not have an option to override pathStyle and endpoint

Signed-off-by: Asif Bashar <abashar@apple.com>

---------

Signed-off-by: Asif Bashar <abashar@apple.com>
Signed-off-by: sunqijun.jun <sunqijun.jun@bytedance.com>
tandonks pushed a commit to tandonks/OpenSearch that referenced this pull request Aug 5, 2025
… not have an option to override path_style_access and endpoint opensearch-project#18796 (opensearch-project#18855)

* Repository s3 plugin test S3RepositoryThirdPartyTests.java does not have an option to override pathStyle and endpoint

Signed-off-by: Asif Bashar <abashar@apple.com>

* Repository s3 plugin test S3RepositoryThirdPartyTests.java does not have an option to override pathStyle and endpoint

Signed-off-by: Asif Bashar <abashar@apple.com>

* Repository s3 plugin test S3RepositoryThirdPartyTests.java does not have an option to override pathStyle and endpoint

Signed-off-by: Asif Bashar <abashar@apple.com>

* Repository s3 plugin test S3RepositoryThirdPartyTests.java does not have an option to override pathStyle and endpoint

Signed-off-by: Asif Bashar <abashar@apple.com>

---------

Signed-off-by: Asif Bashar <abashar@apple.com>
vinaykpud pushed a commit to vinaykpud/OpenSearch that referenced this pull request Sep 26, 2025
… not have an option to override path_style_access and endpoint opensearch-project#18796 (opensearch-project#18855)

* Repository s3 plugin test S3RepositoryThirdPartyTests.java does not have an option to override pathStyle and endpoint

Signed-off-by: Asif Bashar <abashar@apple.com>

* Repository s3 plugin test S3RepositoryThirdPartyTests.java does not have an option to override pathStyle and endpoint

Signed-off-by: Asif Bashar <abashar@apple.com>

* Repository s3 plugin test S3RepositoryThirdPartyTests.java does not have an option to override pathStyle and endpoint

Signed-off-by: Asif Bashar <abashar@apple.com>

* Repository s3 plugin test S3RepositoryThirdPartyTests.java does not have an option to override pathStyle and endpoint

Signed-off-by: Asif Bashar <abashar@apple.com>

---------

Signed-off-by: Asif Bashar <abashar@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants