[BUG] Repository s3 plugin test S3RepositoryThirdPartyTests.java does not have an option to override path_style_access and endpoint #18796#18855
Conversation
…ave an option to override pathStyle and endpoint Signed-off-by: Asif Bashar <abashar@apple.com>
|
❌ Gradle check result for dc6614a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…ave an option to override pathStyle and endpoint Signed-off-by: Asif Bashar <abashar@apple.com>
|
❌ Gradle check result for 9e199bb: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Gradle test passed, Failure unrelated where a jdk download failed for macos FAILURE: Build failed with an exception.
|
…ave an option to override pathStyle and endpoint Signed-off-by: Asif Bashar <abashar@apple.com>
|
❌ Gradle check result for 9dd835c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…ave an option to override pathStyle and endpoint Signed-off-by: Asif Bashar <abashar@apple.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #18855 +/- ##
============================================
+ Coverage 72.79% 72.81% +0.02%
- Complexity 68627 68635 +8
============================================
Files 5572 5577 +5
Lines 315196 315375 +179
Branches 45750 45772 +22
============================================
+ Hits 229454 229655 +201
+ Misses 67153 67078 -75
- Partials 18589 18642 +53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… not have an option to override path_style_access and endpoint opensearch-project#18796 (opensearch-project#18855) * Repository s3 plugin test S3RepositoryThirdPartyTests.java does not have an option to override pathStyle and endpoint Signed-off-by: Asif Bashar <abashar@apple.com> * Repository s3 plugin test S3RepositoryThirdPartyTests.java does not have an option to override pathStyle and endpoint Signed-off-by: Asif Bashar <abashar@apple.com> * Repository s3 plugin test S3RepositoryThirdPartyTests.java does not have an option to override pathStyle and endpoint Signed-off-by: Asif Bashar <abashar@apple.com> * Repository s3 plugin test S3RepositoryThirdPartyTests.java does not have an option to override pathStyle and endpoint Signed-off-by: Asif Bashar <abashar@apple.com> --------- Signed-off-by: Asif Bashar <abashar@apple.com> Signed-off-by: sunqijun.jun <sunqijun.jun@bytedance.com>
… not have an option to override path_style_access and endpoint opensearch-project#18796 (opensearch-project#18855) * Repository s3 plugin test S3RepositoryThirdPartyTests.java does not have an option to override pathStyle and endpoint Signed-off-by: Asif Bashar <abashar@apple.com> * Repository s3 plugin test S3RepositoryThirdPartyTests.java does not have an option to override pathStyle and endpoint Signed-off-by: Asif Bashar <abashar@apple.com> * Repository s3 plugin test S3RepositoryThirdPartyTests.java does not have an option to override pathStyle and endpoint Signed-off-by: Asif Bashar <abashar@apple.com> * Repository s3 plugin test S3RepositoryThirdPartyTests.java does not have an option to override pathStyle and endpoint Signed-off-by: Asif Bashar <abashar@apple.com> --------- Signed-off-by: Asif Bashar <abashar@apple.com>
… not have an option to override path_style_access and endpoint opensearch-project#18796 (opensearch-project#18855) * Repository s3 plugin test S3RepositoryThirdPartyTests.java does not have an option to override pathStyle and endpoint Signed-off-by: Asif Bashar <abashar@apple.com> * Repository s3 plugin test S3RepositoryThirdPartyTests.java does not have an option to override pathStyle and endpoint Signed-off-by: Asif Bashar <abashar@apple.com> * Repository s3 plugin test S3RepositoryThirdPartyTests.java does not have an option to override pathStyle and endpoint Signed-off-by: Asif Bashar <abashar@apple.com> * Repository s3 plugin test S3RepositoryThirdPartyTests.java does not have an option to override pathStyle and endpoint Signed-off-by: Asif Bashar <abashar@apple.com> --------- Signed-off-by: Asif Bashar <abashar@apple.com>
Issue #18796
Description
Describe the bug
[Repository s3 plugin test S3RepositoryThirdPartyTests.java does not have an option to override path_style_access and endpoint for integration tests, this helps to test for different possible s3 settings.
With the fix we will be able to test any changes with above 2 settings variations ,
Current integration test is, AWS_REGION=us-west-2 amazon_s3_access_key=$AWS_ACCESS_KEY_ID amazon_s3_secret_key=$AWS_SECRET_ACCESS_KEY amazon_s3_base_path=path amazon_s3_bucket=dblock-opensearch ./gradlew :plugins:repository-s3:s3ThirdPartyTest
With this chaange, we will also pass custom path_style_access and endpoint.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.