Skip to content

Adds a getter for searchContext in FetchContext #18951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
owaiskazi19 wants to merge 1 commit into from
Closed

Adds a getter for searchContext in FetchContext #18951

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion server/src/main/java/org/opensearch/search/fetch/FetchContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,12 +102,19 @@ public IndexSettings getIndexSettings() {
}

/**
* The {@code SearchLookup} for the this context
* The {@code SearchLookup} for this context
*/
public SearchLookup searchLookup() {
return searchLookup;
}

/**
* The search context of the request
*/
public SearchContext searchContext() {
return searchContext;
}

Comment on lines +111 to +117
Copy link
Copy Markdown
Contributor

@msfroh msfroh Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copying this comment to code so that it needs to be resolved:

@owaiskazi19, What do you need from SearchContext that you're not already getting?

It looks like FetchContext was specifically designed to provide read-only access to specific fields from SearchContext. I'm concerned that if FetchContext starts to expose the whole SearchContext, then that includes all of the setters, so it's no longer an immutable view.

Copy link
Copy Markdown
Member Author

@owaiskazi19 owaiskazi19 Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msfroh figured out a way to handle this in the neural search side without exposing searchcontext in FetchContext. Will close this PR

/**
* The original query
*/
Expand Down
Loading