Skip to content

Update permission for read in /sys/fs/cgroup/system.slice/- path#18987

Merged
peterzhuamazon merged 2 commits intoopensearch-project:3.2from
peterzhuamazon:update-cgroup-permission2
Aug 8, 2025
Merged

Update permission for read in /sys/fs/cgroup/system.slice/- path#18987
peterzhuamazon merged 2 commits intoopensearch-project:3.2from
peterzhuamazon:update-cgroup-permission2

Conversation

@peterzhuamazon
Copy link
Copy Markdown
Member

@peterzhuamazon peterzhuamazon commented Aug 8, 2025

Description

Update permission for read in /sys/fs/cgroup/system.slice/- path.

If running in docker the folder location changed compares to #18975:

/sys/fs/cgroup/system.slice/<>.service/memory.max

becomes

/sys/fs/cgroup/system.slice/docker-89906b83d995faf977d24e8d25bc465a5df6c0eb0a51deedb9aae6b929b85ce1.scope/system.slice/opensearch.service/memory.max

Related Issues

Follow up #18975

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Copy link
Copy Markdown
Member

@cwperks cwperks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as its not possible to use syntax like /sys/fs/cgroup/system.slice/*/system.slice/opensearch.service/-

Edit: FilePermission in JSM never supported wildcards within the path..only at the end. See https://docs.oracle.com/en/java/javase/12/docs//api/java.base/java/io/FilePermission.html

In JDK21 and prior I think the JDK would allow implicit access.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
Copy link
Copy Markdown
Member Author

peterzhuamazon commented Aug 8, 2025

Added a TODO so we will change this later when wildcard in path is supported later.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 8, 2025

❕ Gradle check result for 3b2f47d: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.93%. Comparing base (7ff34ac) to head (3b2f47d).
⚠️ Report is 2 commits behind head on 3.2.

Additional details and impacted files
@@            Coverage Diff            @@
##                3.2   #18987   +/-   ##
=========================================
  Coverage     72.93%   72.93%           
- Complexity    69352    69368   +16     
=========================================
  Files          5643     5643           
  Lines        318713   318713           
  Branches      46112    46112           
=========================================
+ Hits         232441   232468   +27     
+ Misses        67488    67446   -42     
- Partials      18784    18799   +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@peterzhuamazon peterzhuamazon merged commit 42a7209 into opensearch-project:3.2 Aug 8, 2025
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in Engineering Effectiveness Board Aug 8, 2025
@peterzhuamazon peterzhuamazon deleted the update-cgroup-permission2 branch August 8, 2025 16:40
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 8, 2025
…8987)

* Update permission for read in /sys/fs/cgroup/system.slice/- path

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Update TODO comment

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

---------

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
(cherry picked from commit 42a7209)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gaiksaya pushed a commit that referenced this pull request Aug 8, 2025
…8987) (#18992)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
RajatGupta02 pushed a commit to RajatGupta02/OpenSearch that referenced this pull request Aug 18, 2025
…ensearch-project#18987) (opensearch-project#18992)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kh3ra pushed a commit to kh3ra/OpenSearch that referenced this pull request Sep 5, 2025
…ensearch-project#18987) (opensearch-project#18992)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vinaykpud pushed a commit to vinaykpud/OpenSearch that referenced this pull request Sep 26, 2025
…ensearch-project#18987) (opensearch-project#18992)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants