Remove Circuit Breaker check from File Cache put and compute#19135
Remove Circuit Breaker check from File Cache put and compute#19135Gagan6164 wants to merge 5 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Gagan Singh Saini <gagasa@amazon.com>
Gagan6164
requested review from
a team,
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
|
❌ Gradle check result for 1c5a01d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Gagan Singh Saini <gagasa@amazon.com>
|
❌ Gradle check result for 9e02c05: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Gagan Singh Saini <gagasa@amazon.com>
|
❌ Gradle check result for a5140f4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Gagan Singh Saini <gagasa@amazon.com>
|
❌ Gradle check result for 2e35bd0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Could you describe the reason for the PR? |
Signed-off-by: Gagan Singh Saini <gagasa@amazon.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19135 +/- ##
============================================
- Coverage 72.91% 72.83% -0.09%
+ Complexity 69478 69413 -65
============================================
Files 5648 5648
Lines 319272 319261 -11
Branches 46183 46183
============================================
- Hits 232811 232531 -280
- Misses 67641 67947 +306
+ Partials 18820 18783 -37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-actions
bot
added
enhancement
@kkewwei I have created an issue describing the motivation behind this change. |
| private final CircuitBreaker circuitBreaker; | ||
|
|
||
| public FileCache(SegmentedCache<Path, CachedIndexInput> cache, CircuitBreaker circuitBreaker) { | ||
| public FileCache(SegmentedCache<Path, CachedIndexInput> cache) { |
There was a problem hiding this comment.
Since FileCache is annotated as a Public API, this would be a breaking change.
Can we add a new constructor instead and call this constructor with a NoOpCircuitBreaker as the default ?
Gagan6164
force-pushed
the
removeCircuitBreakerInFileCache
branch
from
4fffb63 to
9360d12
Compare
|
❌ Gradle check result for 9360d12: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
3 participants
Description
Remove Circuit Breaker check from File Cache put and compute
Related Issues
Resolves #19137
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.