Change field data cache size setting defaults#19152
Change field data cache size setting defaults#19152jainankitk merged 21 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
|
❌ Gradle check result for 285140f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Flaky test: #14407 |
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
|
❌ Gradle check result for 1d5dd75: TIMEOUT Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
|
❌ Gradle check result for 0c7ffe5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Flaky test: #19325 |
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
|
❌ Gradle check result for d5d2141: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Flaky test: #18938 |
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
|
❌ Gradle check result for b4b8d95: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Unrelated failures: Retrying gradle check |
|
❌ Gradle check result for b4b8d95: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
--------- Signed-off-by: Peter Alfonsi <petealft@amazon.com> Co-authored-by: Peter Alfonsi <petealft@amazon.com>
Description
Changes field data cache size setting to default to 35% rather than no limit (-1). Previously, by default the FD cache was only limited by the (separate) field breaker setting at 40% of heap size, which would confusingly stop further requests rather than just evicting. Also makes the size setting dynamic.
As mentioned in the original issue, I'm open to changing the actual values from 35% and 40% to whatever people think is reasonable. See original issue for reasoning behind the two settings having different values.
Related Issues
Resolves #19104
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.