Attempt to fix the jdt formatter error

[prudhvigodithi]

Description

Seeing https://github.com/diffplug/spotless/blob/main/plugin-gradle/README.md#eclipse-jdt Attempt to fix the jdt formatter error which is seen failing on recent open PR's.

https://github.com/opensearch-project/OpenSearch/actions/runs/17335154878/job/49219860173?pr=19188

* What went wrong:
A problem occurred configuring project ':build-tools'.
> Could not create task ':build-tools:spotlessJava'.
   > java.io.IOException: Failed to load eclipse jdt formatter: java.lang.RuntimeException: java.net.SocketException: Network is unreachable

The issue started because the https://mirror.umd.edu/eclipse/eclipse/updates/4.29 mirror is not accessible.

Related Issues

Seeing on all open PR's #19188

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[prudhvigodithi]

Adding @reta @cwperks @getsaurabh02 to please take a look. Thanks

[prudhvigodithi]

If this dint work we can explore https://download.eclipse.org/oomph/archive/mirror.php?location=eclipse/updates/4.29

[github-actions]

❌ Gradle check result for 7561fe2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 7561fe2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 6a74ac5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[owaiskazi19]

This can be?

Suggested change

	eclipse().withP2Mirrors(['https://download.eclipse.org/eclipse/updates/4.29/':'https://ftp.osuosl.org/pub/eclipse/eclipse/updates/4.29/']).configFile rootProject.file('buildSrc/formatterConfig.xml')
	eclipse().withP2Mirrors(Map.of("https://download.eclipse.org/eclipse/updates/4.29/", "https://ftp.osuosl.org/pub/eclipse/eclipse/updates/4.29/")).configFile rootProject.file('buildSrc/formatterConfig.xml')

[prudhvigodithi]

Initially we use Map.of (#17172) which works, but just following the instructions in https://github.com/diffplug/spotless/blob/main/plugin-gradle/README.md#eclipse-jdt

[owaiskazi19]

@prudhvigodithi Map worked too https://github.com/opensearch-project/neural-search/pull/1540/files.
Nvm, I see mirrors are completely removed

[reta]

I believe this is not new issue [1], has been surfacing since spotless 7.0.0 release (if I am not mistaken), probably the best option is to downgrade spotless to 6.x

[1] diffplug/spotless#2515

[github-actions]

❌ Gradle check result for 6a74ac5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 6a74ac5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[cwperks]

I'm still seeing:

 [3.1.0] FAILURE: Build failed with an exception.
 [3.1.0] 
 [3.1.0] * Where:
 [3.1.0] Build file '/var/jenkins/workspace/gradle-check/search/distribution/bwc/staged/build/bwc/checkout-3.1/buildSrc/build.gradle' line: 275
 [3.1.0] 
 [3.1.0] * What went wrong:
 [3.1.0] A problem occurred configuring project ':build-tools'.
 [3.1.0] > Could not create task ':build-tools:spotlessJava'.
 [3.1.0]    > java.io.IOException: Failed to load eclipse jdt formatter: java.lang.RuntimeException: java.net.NoRouteToHostException: No route to host

[cwperks]

@prudhvigodithi do we potentially need to add this to other branches?

[prudhvigodithi]

I'm thinking to completely remove withP2Mirrors and allow eclipse() to default use https://download.eclipse.org/. As seeing the instructions the mirrors https://github.com/diffplug/spotless/blob/main/plugin-gradle/README.md#eclipse-jdt are only for restricted scenarios and also withP2Mirrors setting defaults to mirror. It would be nice if there is a setting 1st it would try https://download.eclipse.org/ and then fallback to mirror.

[prudhvigodithi]

@prudhvigodithi do we potentially need to add this to other branches?

Yes @cwperks we need to backport to the relevant branches , IMO we need to force merge and backport as the configured mirror is completely down https://mirror.umd.edu/eclipse/eclipse/updates/4.29.

[github-actions]

❌ Gradle check result for d7213a4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[opensearch-trigger-bot]

The backport to 2.18 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.18 2.18
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.18
# Create a new branch
git switch --create backport/backport-19199-to-2.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4fc44d10caa18c9280cf5ad8377dc1f1cdfa4599
# Push it to GitHub
git push --set-upstream origin backport/backport-19199-to-2.18
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.18

Then, create a pull request where the base branch is 2.18 and the compare/head branch is backport/backport-19199-to-2.18.

[prudhvigodithi]

#19199 (comment) we dont need to backport to 2.18 as I dont see the mirrors added to 2.18 https://github.com/opensearch-project/OpenSearch/blob/2.18/gradle/formatting.gradle#L85.