Replace deprecated AccessController in :server#19239
Merged
andrross merged 1 commit intoopensearch-project:mainfrom Sep 15, 2025
Merged
Replace deprecated AccessController in :server#19239andrross merged 1 commit intoopensearch-project:mainfrom
andrross merged 1 commit intoopensearch-project:mainfrom
Conversation
Use the drop-in replacement for the deprecated AccessController where appropriate. Also remove tests that were assuming a security manager was present as that can never be true post JDK 21. Signed-off-by: Andrew Ross <andrross@amazon.com>
Contributor
|
❌ Gradle check result for 4dc5c4f: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
|
❕ Gradle check result for 4dc5c4f: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19239 +/- ##
============================================
+ Coverage 72.79% 72.90% +0.11%
- Complexity 69605 69722 +117
============================================
Files 5658 5658
Lines 320079 320071 -8
Branches 46345 46345
============================================
+ Hits 232996 233363 +367
+ Misses 68230 67799 -431
- Partials 18853 18909 +56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cwperks
reviewed
Sep 12, 2025
asimmahmood1
pushed a commit
to jainankitk/OpenSearch
that referenced
this pull request
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the drop-in replacement for the deprecated AccessController where appropriate. Also remove tests that were assuming a security manager was present as that can never be true post JDK 21.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.