Skip to content

Replace deprecated AccessController in :server#19239

Merged
andrross merged 1 commit intoopensearch-project:mainfrom
andrross:server-access-controller
Sep 15, 2025
Merged

Replace deprecated AccessController in :server#19239
andrross merged 1 commit intoopensearch-project:mainfrom
andrross:server-access-controller

Conversation

@andrross
Copy link
Copy Markdown
Member

@andrross andrross commented Sep 4, 2025

Use the drop-in replacement for the deprecated AccessController where appropriate. Also remove tests that were assuming a security manager was present as that can never be true post JDK 21.

Check List

  • Functionality includes testing.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Use the drop-in replacement for the deprecated AccessController where
appropriate. Also remove tests that were assuming a security manager was
present as that can never be true post JDK 21.

Signed-off-by: Andrew Ross <andrross@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 4, 2025

❌ Gradle check result for 4dc5c4f: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 5, 2025

❕ Gradle check result for 4dc5c4f: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 5, 2025

Codecov Report

❌ Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.90%. Comparing base (3e747cb) to head (4dc5c4f).
⚠️ Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
...arch/index/store/remote/utils/TransferManager.java 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19239      +/-   ##
============================================
+ Coverage     72.79%   72.90%   +0.11%     
- Complexity    69605    69722     +117     
============================================
  Files          5658     5658              
  Lines        320079   320071       -8     
  Branches      46345    46345              
============================================
+ Hits         232996   233363     +367     
+ Misses        68230    67799     -431     
- Partials      18853    18909      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@cwperks cwperks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking this on @andrross! The change LGTM. It will be nice to get rid of those deprecation messages in the IDE.

@andrross andrross merged commit a3ac746 into opensearch-project:main Sep 15, 2025
87 of 95 checks passed
@andrross andrross deleted the server-access-controller branch September 15, 2025 20:49
jainankitk pushed a commit to jainankitk/OpenSearch that referenced this pull request Sep 22, 2025
)

Use the drop-in replacement for the deprecated AccessController where
appropriate. Also remove tests that were assuming a security manager was
present as that can never be true post JDK 21.

Signed-off-by: Andrew Ross <andrross@amazon.com>
jainankitk pushed a commit to jainankitk/OpenSearch that referenced this pull request Sep 22, 2025
)

Use the drop-in replacement for the deprecated AccessController where
appropriate. Also remove tests that were assuming a security manager was
present as that can never be true post JDK 21.

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: Ankit Jain <jainankitk@apache.org>
jainankitk pushed a commit to jainankitk/OpenSearch that referenced this pull request Sep 22, 2025
)

Use the drop-in replacement for the deprecated AccessController where
appropriate. Also remove tests that were assuming a security manager was
present as that can never be true post JDK 21.

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: Ankit Jain <jainankitk@apache.org>
asimmahmood1 pushed a commit to jainankitk/OpenSearch that referenced this pull request Sep 23, 2025
)

Use the drop-in replacement for the deprecated AccessController where
appropriate. Also remove tests that were assuming a security manager was
present as that can never be true post JDK 21.

Signed-off-by: Andrew Ross <andrross@amazon.com>
pranikum pushed a commit to pranikum/OpenSearch that referenced this pull request Sep 23, 2025
)

Use the drop-in replacement for the deprecated AccessController where
appropriate. Also remove tests that were assuming a security manager was
present as that can never be true post JDK 21.

Signed-off-by: Andrew Ross <andrross@amazon.com>
vinaykpud pushed a commit to vinaykpud/OpenSearch that referenced this pull request Sep 26, 2025
)

Use the drop-in replacement for the deprecated AccessController where
appropriate. Also remove tests that were assuming a security manager was
present as that can never be true post JDK 21.

Signed-off-by: Andrew Ross <andrross@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants