Update ide.gradle to write --add-modules to .idea/compiler.xml.#19331
Closed
finnegancarroll wants to merge 2 commits intoopensearch-project:mainfrom
Closed
Update ide.gradle to write --add-modules to .idea/compiler.xml.#19331finnegancarroll wants to merge 2 commits intoopensearch-project:mainfrom
finnegancarroll wants to merge 2 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Contributor
|
❌ Gradle check result for 7b69fd0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
Author
|
Edit - Fixed: |
Contributor
|
❌ Gradle check result for 7b69fd0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
|
❕ Gradle check result for 7b69fd0: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19331 +/- ##
============================================
- Coverage 72.88% 72.82% -0.07%
+ Complexity 69841 69793 -48
============================================
Files 5673 5673
Lines 320756 320756
Branches 46370 46370
============================================
- Hits 233796 233589 -207
- Misses 68102 68233 +131
- Partials 18858 18934 +76 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Sep 18, 2025
Contributor
|
❌ Gradle check result for 7b69fd0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
|
❌ Gradle check result for 7b69fd0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
|
❌ Gradle check result for 7b69fd0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
|
This PR is stalled because it has been open for 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I notice that IntelliJ will sometimes produce the error:
This appears to be the result of IntelliJ defaulting to its own test runner after a restart/update/cleared cache.
Settings -> Build, Execution, Deployment -> Build Tools -> Gradle will be set to:
"Build and run using: IntelliJ IDEA"
"Run tests using: Choose per test"
When setting these both to "Gradle" the error goes away as gradle is able to find the extra config option as set here:
https://github.com/opensearch-project/OpenSearch/blob/main/libs/common/build.gradle#L54-L57
However using the IntelliJ test runner does not honor the compiler option as configured in the above build.gradle. This change updates ide.gradle to inject this compiler option into
.idea/compiler.xml.Related Issues
N/A
Adding skip-changelog here as it's a dev QOL only change.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.