Revert "Bump log4j2 from 2.21.0 to 2.25.1"#19430
Merged
andrross merged 1 commit intoopensearch-project:mainfrom Sep 26, 2025
Merged
Revert "Bump log4j2 from 2.21.0 to 2.25.1"#19430andrross merged 1 commit intoopensearch-project:mainfrom
andrross merged 1 commit intoopensearch-project:mainfrom
Conversation
This reverts commit b9c5bc7. Signed-off-by: Andrew Ross <andrross@amazon.com>
andrross
requested review from
a team,
Bukhtawar,
CEHENKLE,
Rishikesh1159,
anasalkouz,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
Member
|
Related bug: apache/logging-log4j2#3940 |
Member
|
When inspecting the value of statusToString I get the following stack trace: Test case run: |
cwperks
approved these changes
Sep 26, 2025
Member
|
I see a few calls to setStackTrace in the core, could it be related? |
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19430 +/- ##
============================================
+ Coverage 72.89% 72.98% +0.09%
- Complexity 69911 69967 +56
============================================
Files 5676 5676
Lines 321142 321142
Branches 46429 46429
============================================
+ Hits 234085 234398 +313
+ Misses 68144 67822 -322
- Partials 18913 18922 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 tasks
Contributor
|
Reading the log4j issue that @cwperks linked, it sounds like this could potentially have production impact, at least in terms of either increasing logging or obfuscating logging. Throwing another exception while trying to log an exception feels pretty bad. I'm onboard with reverting. |
msfroh
approved these changes
Sep 26, 2025
66 tasks
5 tasks
Contributor
|
[nit-pick] |
5 tasks
karenyrx
pushed a commit
to karenyrx/OpenSearch
that referenced
this pull request
Sep 29, 2025
…opensearch-project#19430) This reverts commit b9c5bc7. Signed-off-by: Andrew Ross <andrross@amazon.com>
peteralfonsi
pushed a commit
to peteralfonsi/OpenSearch
that referenced
this pull request
Oct 15, 2025
…opensearch-project#19430) This reverts commit b9c5bc7. Signed-off-by: Andrew Ross <andrross@amazon.com>
This was referenced Oct 22, 2025
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit b9c5bc7 from #19184
The log4j update has introduced flakiness in a test (#19325) for an unknown reason. It also has downstream impact on plugins due to the addition of error prone annotations as an API dependency in
:server. I don't understand the changes to OpenSearchTestCase, or why we now have a flaky test, so I'm putting out this revert PR. Unfortunately if we do commit this revert then plugins that have already updated to deal with the error prone annotation change will have to make another change.I'm open to other suggestions to fix the test. @cwperks was able to stabilize the tests with #19426, but neither of us understand why that would be necessary.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.