[Bugfix] Implement SslHandler retrieval logic for transport-reactor-netty4 plugin

[reta]

Description

Originally was posted on the OpenSearch forum [1], when transport-reactor-netty4 plugin is activated, some functionality related to opensearch-security plugin is not working properly.

$ ./plugins/opensearch-security/tools/securityadmin.sh -dg -cacert config/root-ca.pem  -cert config/node1.pem -w
WARNING: nor OPENSEARCH_JAVA_HOME nor JAVA_HOME is set, will use /usr/bin/java
Listening for transport dt_socket at address: 5005
Security Admin v7
Will connect to localhost:9200 ... done
Listening for transport dt_socket at address: 5005
ERR: An unexpected ResponseException occured: method [GET], host [https://localhost:9200], URI [/_plugins/_security/whoami], status line [HTTP/2.0 403 Forbidden]
No security data
Trace:
org.opensearch.client.ResponseException: method [GET], host [https://localhost:9200], URI [/_plugins/_security/whoami], status line [HTTP/2.0 403 Forbidden]
No security data
        at org.opensearch.client.RestClient.convertResponse(RestClient.java:501)
        at org.opensearch.client.RestClient.performRequest(RestClient.java:384)
        at org.opensearch.client.RestClient.performRequest(RestClient.java:359)
        at org.opensearch.security.tools.SecurityAdmin.execute(SecurityAdmin.java:541)
        at org.opensearch.security.tools.SecurityAdmin.main(SecurityAdmin.java:154)

It turned out the that issue was related to the SslHandler that opensearch-security tries to locate by name. The transport-reactor-netty4 plugin does use different naming convention and as such, the SslHandler has not being detected.

[1] https://forum.opensearch.org/t/pods-not-coming-up-after-using-transport-reactor-netty4-plugin-for-mcp-server/26990

Related Issues

See please https://forum.opensearch.org/t/pods-not-coming-up-after-using-transport-reactor-netty4-plugin-for-mcp-server/26990

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

❌ Gradle check result for a71f92e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[reta]

@andrross @cwperks would appreciate a look, would be great to have it for 3.3.0 (pretty minor fix), thank you!

[github-actions]

❌ Gradle check result for 756e996: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

✅ Gradle check result for 756e996: SUCCESS

[codecov]

Codecov Report

❌ Patch coverage is 6.89655% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.98%. Comparing base (28689b7) to head (756e996).
⚠️ Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
...p/reactor/netty4/ReactorNetty4BaseHttpChannel.java	0.00%	25 Missing ⚠️
...r/netty4/ReactorNetty4NonStreamingHttpChannel.java	0.00%	1 Missing ⚠️
...ctor/netty4/ReactorNetty4StreamingHttpChannel.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #19458      +/-   ##
============================================
+ Coverage     72.96%   72.98%   +0.02%     
+ Complexity    69969    69950      -19     
============================================
  Files          5676     5677       +1     
  Lines        321265   321285      +20     
  Branches      46445    46450       +5     
============================================
+ Hits         234407   234503      +96     
+ Misses        67901    67806      -95     
- Partials      18957    18976      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.