Skip to content

Fix derived query rewrite#19496

Merged
jainankitk merged 2 commits intoopensearch-project:mainfrom
harshavamsi:derived_fix
Oct 4, 2025
Merged

Fix derived query rewrite#19496
jainankitk merged 2 commits intoopensearch-project:mainfrom
harshavamsi:derived_fix

Conversation

@harshavamsi
Copy link
Copy Markdown
Contributor

Description

Reverts derived field rewrite and chooses to rewrite queries based on the type of query

Related Issues

Resolves #19337

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 1, 2025

❌ Gradle check result for 51ed781: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@jainankitk jainankitk added the backport 3.3 Backport to 3.3 branch label Oct 2, 2025
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 2, 2025

❌ Gradle check result for 8e09b8f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 2, 2025

❌ Gradle check result for d6dd68a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@harshavamsi harshavamsi closed this Oct 3, 2025
@harshavamsi harshavamsi reopened this Oct 3, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 3, 2025

❌ Gradle check result for d6dd68a: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@jainankitk
Copy link
Copy Markdown
Contributor

@harshavamsi - Can you merge main into your branch?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 4, 2025

❕ Gradle check result for d6dd68a: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 4, 2025

Codecov Report

❌ Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.95%. Comparing base (1633e1a) to head (d6dd68a).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
.../org/opensearch/index/query/DerivedFieldQuery.java 82.35% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19496      +/-   ##
============================================
- Coverage     73.07%   72.95%   -0.12%     
+ Complexity    70414    70391      -23     
============================================
  Files          5708     5708              
  Lines        322502   322519      +17     
  Branches      46705    46711       +6     
============================================
- Hits         235653   235306     -347     
- Misses        67865    68322     +457     
+ Partials      18984    18891      -93     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jainankitk jainankitk merged commit 0c3a313 into opensearch-project:main Oct 4, 2025
56 of 69 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 4, 2025
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
(cherry picked from commit 0c3a313)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
rishabhmaurya pushed a commit that referenced this pull request Oct 4, 2025
(cherry picked from commit 0c3a313)

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Oct 15, 2025
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
@harshavamsi harshavamsi deleted the derived_fix branch November 25, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 3.3 Backport to 3.3 branch bug Something isn't working lucene Search Search query, autocomplete ...etc v3.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Removing rewrite for derived fields

3 participants