Skip to content

[Backport 3.3] Streaming aggregation planning to determine the appropriate flush mode#19512

Merged
rishabhmaurya merged 1 commit into3.3from
backport/backport-19488-to-3.3
Oct 3, 2025
Merged

[Backport 3.3] Streaming aggregation planning to determine the appropriate flush mode#19512
rishabhmaurya merged 1 commit into3.3from
backport/backport-19488-to-3.3

Conversation

@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

Backport c851fdf from #19488.

#19488)

* Planning for flush mode for streaming aggs

Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>

* Address PR comments

Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>

* Fix for nested aggs and more unit tests

Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>

* Integ test to validate stream agg used using profile output

Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>

* Make StreamNumericTermsAggregator streamable

Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>

* Integ test for StreamNumericTermsAggregator

Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>

* Improve coverage and PR comments

Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>

* Minor refactor and address PR comments

Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>

---------

Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
(cherry picked from commit c851fdf)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 3, 2025

❌ Gradle check result for 9c2a16a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 3, 2025

❌ Gradle check result for 9c2a16a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 3, 2025

✅ Gradle check result for 9c2a16a: SUCCESS

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 3, 2025

Codecov Report

❌ Patch coverage is 73.14286% with 47 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (3.3@0f360bb). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...nsearch/search/streaming/StreamingCostMetrics.java 55.88% 9 Missing and 6 partials ⚠️
...opensearch/search/streaming/FlushModeResolver.java 79.16% 4 Missing and 6 partials ⚠️
...ons/bucket/terms/StreamNumericTermsAggregator.java 76.47% 5 Missing and 3 partials ⚠️
.../org/opensearch/search/internal/SearchContext.java 20.00% 4 Missing ⚠️
...h/search/aggregations/AggregatorTreeEvaluator.java 82.35% 2 Missing and 1 partial ⚠️
...ions/bucket/terms/StreamStringTermsAggregator.java 83.33% 2 Missing and 1 partial ⚠️
...regations/bucket/terms/TermsAggregatorFactory.java 50.00% 0 Missing and 2 partials ⚠️
...ensearch/search/internal/ContextIndexSearcher.java 0.00% 0 Missing and 1 partial ⚠️
...earch/profile/aggregation/ProfilingAggregator.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             3.3   #19512   +/-   ##
======================================
  Coverage       ?   73.04%           
  Complexity     ?    70495           
======================================
  Files          ?     5716           
  Lines          ?   322926           
  Branches       ?    46770           
======================================
  Hits           ?   235877           
  Misses         ?    68079           
  Partials       ?    18970           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rishabhmaurya rishabhmaurya merged commit 64637ae into 3.3 Oct 3, 2025
53 of 57 checks passed
@github-actions github-actions bot deleted the backport/backport-19488-to-3.3 branch October 3, 2025 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant