[Backport 3.3] Fix the enforce_hostname_verification check for flight transport#19580
Merged
jainankitk merged 1 commit intoopensearch-project:3.3from Oct 9, 2025
Conversation
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
jainankitk
approved these changes
Oct 9, 2025
Contributor
|
❌ Gradle check result for cbf05b9: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #19580 +/- ##
============================================
- Coverage 72.99% 72.99% -0.01%
- Complexity 70483 70521 +38
============================================
Files 5717 5717
Lines 323051 323055 +4
Branches 46793 46794 +1
============================================
- Hits 235826 235823 -3
+ Misses 68259 68234 -25
- Partials 18966 18998 +32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
66 tasks
This was referenced Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On disabling transport.ssl.enforce_hostname_verification, flight transport still uses goes through hostname verification. Ideally, it should honour this setting and skip verification.
Related Issues
Resolves #19578
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.