Skip to content

Disable query rewriter as a default behaviour#19592

Merged
peterzhuamazon merged 2 commits into
opensearch-project:mainfrom
rishabhmaurya:disable-query-rewriter
Oct 10, 2025
Merged

Disable query rewriter as a default behaviour#19592
peterzhuamazon merged 2 commits into
opensearch-project:mainfrom
rishabhmaurya:disable-query-rewriter

Conversation

@rishabhmaurya
Copy link
Copy Markdown
Contributor

@rishabhmaurya rishabhmaurya commented Oct 9, 2025

Description

Disable query rewriter(#19060) as a default behaviour. There have been several issues reported so far. Listing them here soon

Related Issues

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@getsaurabh02
Copy link
Copy Markdown
Member

Thanks @rishabhmaurya . We should highlight the related/reported issues here for tracking.

Does this also need any documentation change as it's a change in settings default behaviour?

@rishabhmaurya rishabhmaurya force-pushed the disable-query-rewriter branch from a7fc4c0 to da9a537 Compare October 9, 2025 23:56
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
@rishabhmaurya rishabhmaurya force-pushed the disable-query-rewriter branch from da9a537 to 8506d93 Compare October 9, 2025 23:58
@andrross
Copy link
Copy Markdown
Member

We should highlight the related/reported issues here for tracking.

@getsaurabh02 @rishabhmaurya I added the 3 issues I'm aware of to the description

Comment thread CHANGELOG.md Outdated
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
@jainankitk
Copy link
Copy Markdown
Contributor

@peterzhuamazon - Do we need the backport label since we have the manual backport PR already open?

@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for a010db9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@rishabhmaurya rishabhmaurya removed the backport 3.3 Backport to 3.3 branch label Oct 10, 2025
@peterzhuamazon
Copy link
Copy Markdown
Member

@peterzhuamazon - Do we need the backport label since we have the manual backport PR already open?

Nope, I didnt realize there was a manual backport, see Rishabh already remove the label now 👍

@github-actions
Copy link
Copy Markdown
Contributor

✅ Gradle check result for a010db9: SUCCESS

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.97%. Comparing base (8a1c55f) to head (a010db9).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19592      +/-   ##
============================================
- Coverage     73.07%   72.97%   -0.11%     
+ Complexity    70635    70569      -66     
============================================
  Files          5723     5723              
  Lines        323490   323490              
  Branches      46851    46851              
============================================
- Hits         236401   236054     -347     
- Misses        67977    68469     +492     
+ Partials      19112    18967     -145     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@peterzhuamazon peterzhuamazon merged commit affc455 into opensearch-project:main Oct 10, 2025
43 of 46 checks passed
rgsriram pushed a commit to rgsriram/OpenSearch that referenced this pull request Oct 11, 2025
* Disable query rewriter as a default behaviour

Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>

* move change log entry to release notes

Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>

---------

Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Oct 15, 2025
* Disable query rewriter as a default behaviour

Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>

* move change log entry to release notes

Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>

---------

Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants