[Bug Fix] [Star Tree] Fix sub-aggregator casting for search with profile=true#19652
Merged
sandeshkr419 merged 2 commits intoopensearch-project:mainfrom Oct 16, 2025
Merged
[Bug Fix] [Star Tree] Fix sub-aggregator casting for search with profile=true#19652sandeshkr419 merged 2 commits intoopensearch-project:mainfrom
sandeshkr419 merged 2 commits intoopensearch-project:mainfrom
Conversation
sandeshkr419
requested review from
a team,
Bukhtawar,
CEHENKLE,
Rishikesh1159,
anasalkouz,
andrross,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
sandeshkr419
changed the title
Contributor
|
❌ Gradle check result for bc8d931: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
bharath-techie
approved these changes
Oct 16, 2025
Contributor
|
LGTM! |
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Contributor
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 16, 2025
…ile=true (#19652) * fix sub-aggregator casting when used with profile=true Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com> --------- Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com> (cherry picked from commit b9781c1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sandeshkr419
added a commit
that referenced
this pull request
Oct 17, 2025
…earch with profile=true (#19669) * [Bug Fix] [Star Tree] Fix sub-aggregator casting for search with profile=true (#19652) * fix sub-aggregator casting when used with profile=true Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com> --------- Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com> (cherry picked from commit b9781c1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix changelog Removed several fixed issues from CHANGELOG. Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com> --------- Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sandesh Kumar <sandeshkr419@gmail.com>
rgsriram
pushed a commit
to rgsriram/OpenSearch
that referenced
this pull request
Oct 18, 2025
…ile=true (opensearch-project#19652) * fix sub-aggregator casting when used with profile=true Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com> --------- Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
This was referenced Oct 22, 2025
kh3ra
pushed a commit
to kh3ra/OpenSearch
that referenced
this pull request
Oct 23, 2025
…ile=true (opensearch-project#19652) * fix sub-aggregator casting when used with profile=true Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com> --------- Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
1 task
This was referenced Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix of type-casting issue when aggregator is wrapped in
ProfilingAggregator. While setting sub-aggregators, we need to ensure that the unwrapped aggregator is passed back.Also, refactored few pieces of the code to remove redundant methods.
Related Issues
Resolves #19649
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.