Skip to content

Replace java.security.AccessController with org.opensearch.secure_sm.AccessController in discovery plugins#19802

Merged
cwperks merged 4 commits intoopensearch-project:mainfrom
cwperks:remove-access
Nov 7, 2025
Merged

Replace java.security.AccessController with org.opensearch.secure_sm.AccessController in discovery plugins#19802
cwperks merged 4 commits intoopensearch-project:mainfrom
cwperks:remove-access

Conversation

@cwperks
Copy link
Copy Markdown
Member

@cwperks cwperks commented Oct 28, 2025

Description

Replace java.security.AccessController with org.opensearch.secure_sm.AccessController in discovery plugins.

Replacing all of these calls in a single PR would be a lot to review, so opting to split up the core by subprojects to replace the calls.

Related Issues

Related to #18339

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…AccessController in discovery plugins

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks cwperks requested a review from a team as a code owner October 28, 2025 19:59
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 0d4c60b: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 0d4c60b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 0896720: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

✅ Gradle check result for 0896720: SUCCESS

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 29, 2025

Codecov Report

❌ Patch coverage is 84.37500% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.16%. Comparing base (39b4a70) to head (670aedc).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...re/classic/management/AzureComputeServiceImpl.java 0.00% 3 Missing ⚠️
.../opensearch/cloud/gce/GceInstancesServiceImpl.java 87.50% 1 Missing ⚠️
.../opensearch/cloud/gce/network/GceNameResolver.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19802      +/-   ##
============================================
- Coverage     73.30%   73.16%   -0.14%     
+ Complexity    71419    71269     -150     
============================================
  Files          5770     5768       -2     
  Lines        325740   325614     -126     
  Branches      47173    47143      -30     
============================================
- Hits         238769   238243     -526     
- Misses        67829    68241     +412     
+ Partials      19142    19130      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 5, 2025

❌ Gradle check result for 670aedc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 7, 2025

❕ Gradle check result for 670aedc: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@cwperks cwperks merged commit b74d032 into opensearch-project:main Nov 7, 2025
34 of 36 checks passed
liuguoqingfz pushed a commit to liuguoqingfz/OpenSearch that referenced this pull request Dec 15, 2025
…AccessController in discovery plugins (opensearch-project#19802)

* Replace java.security.AccessController with org.opensearch.secure_sm.AccessController in discovery plugins

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Fix test

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants