Use TemporaryFolder JUnit @Rule to manage temporary folders in tests

[reta]

Description

Use TemporaryFolder JUnit @rule to manage temporary folders in tests

Related Issues

This is a follow up on #18921 to replace custom folder management with JUnit in tests.

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[reta]

@beanuwave @cwperks would appreciate if you could take a look folks, thank you.

[cwperks]

Thank you @reta ! I guess we will need the suppressions until OpenSearch switches to JUnit 5.

[reta]

Thank you @reta ! I guess we will need the suppressions until OpenSearch switches to JUnit 5.

Thanks @cwperks , yeah, but I suspect we would need Apache Lucene to make a move :)

[github-actions]

❕ Gradle check result for 9934613: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.16%. Comparing base (8dd1286) to head (9934613).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #19806      +/-   ##
============================================
+ Coverage     73.12%   73.16%   +0.03%     
- Complexity    71099    71140      +41     
============================================
  Files          5754     5754              
  Lines        325296   325296              
  Branches      47052    47052              
============================================
+ Hits         237868   237998     +130     
+ Misses        68282    68125     -157     
- Partials      19146    19173      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.