Prevent calling filterFields multiple times on indices with the same mappings in GET _mapping#19914
Draft
cwperks wants to merge 3 commits intoopensearch-project:mainfrom
Draft
Prevent calling filterFields multiple times on indices with the same mappings in GET _mapping#19914cwperks wants to merge 3 commits intoopensearch-project:mainfrom
cwperks wants to merge 3 commits intoopensearch-project:mainfrom
Conversation
…mappings in GET _mapping Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Contributor
|
❌ Gradle check result for 6bff013: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
|
This PR is stalled because it has been open for 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The PR contains a slight optimization for handling GET _mapping API when a fieldFilter is present (particularly in cases where the user has FLS restrictions on indices). The changes in this PR will filter the mappings once for indices which share the same mappings such as in cases with rollover indices.
There are still many issues with the GET _mapping API and its memory consumption, but the changes in this PR present one further optimization that can be done to improve the performance of this API in some cases.
Related Issues
Related to opensearch-project/OpenSearch-Dashboards#10047
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.