Forbid use of ClassLoader APIs for disabling assertions#20000
Merged
andrross merged 1 commit intoopensearch-project:mainfrom Nov 14, 2025
Merged
Forbid use of ClassLoader APIs for disabling assertions#20000andrross merged 1 commit intoopensearch-project:mainfrom
andrross merged 1 commit intoopensearch-project:mainfrom
Conversation
Programmatically disabling assertions in tests will disable assertions for all classes loaded in that JVM instance. This will cause suprious test failures in random tests depending on where and when they get executed. Signed-off-by: Andrew Ross <andrross@amazon.com>
varunbharadwaj
approved these changes
Nov 14, 2025
Contributor
varunbharadwaj
left a comment
varunbharadwaj
left a comment
There was a problem hiding this comment.
Thanks for this change!
cwperks
approved these changes
Nov 14, 2025
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20000 +/- ##
============================================
+ Coverage 73.23% 73.27% +0.03%
- Complexity 71544 71625 +81
============================================
Files 5786 5789 +3
Lines 327013 327056 +43
Branches 47284 47288 +4
============================================
+ Hits 239498 239653 +155
+ Misses 68245 68136 -109
+ Partials 19270 19267 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
PR number 20K :D |
rgsriram
pushed a commit
to rgsriram/OpenSearch
that referenced
this pull request
Dec 5, 2025
…roject#20000) Programmatically disabling assertions in tests will disable assertions for all classes loaded in that JVM instance. This will cause suprious test failures in random tests depending on where and when they get executed. Signed-off-by: Andrew Ross <andrross@amazon.com>
liuguoqingfz
pushed a commit
to liuguoqingfz/OpenSearch
that referenced
this pull request
Dec 15, 2025
…roject#20000) Programmatically disabling assertions in tests will disable assertions for all classes loaded in that JVM instance. This will cause suprious test failures in random tests depending on where and when they get executed. Signed-off-by: Andrew Ross <andrross@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Programmatically disabling assertions in tests will disable assertions for all classes loaded in that JVM instance. This will cause suprious test failures in random tests depending on where and when they get executed.
See #19765 for a case where disabled assertions caused unrelated test failures that took several days to figure out.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.