Replace explicit type conversion with instanceof pattern variable in plugins dir and libs dir#20012
Conversation
…plugins dir and libs dir Signed-off-by: Binlong Gao <gbinlong@amazon.com>
|
❌ Gradle check result for 33e2d12: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
sandeshkr419
left a comment
There was a problem hiding this comment.
LGTM!
Thanks @gaobinlong for putting efforts in refactoring this!
|
❌ Gradle check result for 33e2d12: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Binlong Gao <gbinlong@amazon.com>
|
❕ Gradle check result for 1f9ae8a: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Signed-off-by: Binlong Gao <gbinlong@amazon.com>
Need to handle potential NPE for |
|
❌ Gradle check result for cbb78ef: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
plugins/telemetry-otel/src/main/java/org/opensearch/telemetry/OTelAttributesConverter.java
Show resolved
Hide resolved
…plugins dir and libs dir (opensearch-project#20012)
…plugins dir and libs dir (opensearch-project#20012)
Description
Similar to #19714.
Use the modern instanceof pattern variables instead of explicit type conversions in all moduels, this can improve the code readability and reduce potential ClassCastException risks.
Related Issues
No issue.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.