Skip to content

Fix a flaky test for issue 19915 #20253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrross merged 1 commit into from
Dec 17, 2025
+4 −1
Merged

Fix a flaky test for issue 19915 #20253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion server/src/test/java/org/opensearch/env/NodeMetadataTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,10 @@ public class NodeMetadataTests extends OpenSearchTestCase {
private Version randomVersion() {
// VersionUtils.randomVersion() only returns known versions, which are necessarily no later than Version.CURRENT; however we want
// also to consider our behaviour with all versions, so occasionally pick up a truly random version.
return rarely() ? Version.fromId(randomInt()) : VersionUtils.randomVersion(random());
//
// Version.fromId(...) requires the OpenSearch mask to be present, so we must generate ids in the valid masked range.
// The maximum id used elsewhere in this test class is 234217727 (see tooNewVersion()).
return rarely() ? Version.fromId(between(MASK, 234217727)) : VersionUtils.randomVersion(random());
}

public void testEqualsHashcodeSerialization() {
Expand Down
Loading