Skip to content

Remove legacy v1.x skip tags from YAML REST tests#20374

Merged
cwperks merged 5 commits into
opensearch-project:mainfrom
esl1350:fix.remove-skip-tags-v1
Jan 7, 2026
Merged

Remove legacy v1.x skip tags from YAML REST tests#20374
cwperks merged 5 commits into
opensearch-project:mainfrom
esl1350:fix.remove-skip-tags-v1

Conversation

@esl1350
Copy link
Copy Markdown
Contributor

@esl1350 esl1350 commented Jan 6, 2026

Description

Removes legacy skip tags from YAML REST tests for versions 1.x

Related Issues

Resolves #16574

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Summary by CodeRabbit

  • Tests
    • Removed version-specific skip conditions from multiple REST API specification test files.
    • Tests for cluster management features, node information retrieval, cluster health checks, cluster state operations, node rerouting, cluster statistics, and search functionality now execute on previously excluded version ranges.
    • Improved test coverage ensures better system reliability.

✏️ Tip: You can customize this high-level summary in your review settings.

esl1350 and others added 5 commits December 28, 2025 01:06
Signed-off-by: Elizabeth Liu <esl1350@gmail.com>
Signed-off-by: Elizabeth Liu <esl1350@gmail.com>
Signed-off-by: Elizabeth Liu <esl1350@gmail.com>
@esl1350 esl1350 requested a review from a team as a code owner January 6, 2026 07:29
@github-actions github-actions Bot added enhancement Enhancement or improvement to existing feature or request good first issue Good for newcomers Other labels Jan 6, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 6, 2026

📝 Walkthrough

Walkthrough

This pull request removes legacy version-based skip directives from YAML REST API test files. The removed skips targeted predecessor versions (primarily 1.2.99 and 1.4.99) that are no longer part of the active testing matrix in mixed-cluster and backward-compatibility environments, streamlining the test configuration.

Changes

Cohort / File(s) Summary
CAT API Tests
rest-api-spec/src/main/resources/rest-api-spec/test/cat.cluster_manager/10_basic.yml, rest-api-spec/src/main/resources/rest-api-spec/test/cat.health/10_basic.yml, rest-api-spec/src/main/resources/rest-api-spec/test/cat.nodes/10_basic.yml
Removed skip directives for version " - 1.4.99" across Help and output test sections. Tests now execute without version-based exclusions.
Cluster API Tests
rest-api-spec/src/main/resources/rest-api-spec/test/cluster.health/10_basic.yml, rest-api-spec/src/main/resources/rest-api-spec/test/cluster.reroute/10_basic.yml, rest-api-spec/src/main/resources/rest-api-spec/test/cluster.reroute/20_response_filtering.yml, rest-api-spec/src/main/resources/rest-api-spec/test/cluster.state/10_basic.yml, rest-api-spec/src/main/resources/rest-api-spec/test/cluster.state/20_filtering.yml, rest-api-spec/src/main/resources/rest-api-spec/test/cluster.stats/10_basic.yml
Removed skip blocks that excluded tests for version " - 1.4.99" related to cluster\manager\ node metrics and cluster state filtering.
Nodes API Tests
rest-api-spec/src/main/resources/rest-api-spec/test/nodes.info/10_basic.yml, distribution/docker/src/test/resources/rest-api-spec/test/11_nodes.yml
Removed version " - 1.4.99" skip entry from node\_info role tests, enabling unconditional execution.
Search Tests
rest-api-spec/src/main/resources/rest-api-spec/test/search.aggregation/230_composite.yml, rest-api-spec/src/main/resources/rest-api-spec/test/search/230_interval_query.yml
Removed skip blocks for versions " - 1.2.99" and " - 1.4.99" across composite aggregation and interval query tests.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~8 minutes

Suggested reviewers

  • cwperks
  • msfroh
  • kotwanikunal
  • jed326
  • ashking94
  • owaiskazi19

Poem

🐰 Hops of joy for cleanup day,
Skip blocks vanishing away,
Tests run free, no version gate,
Predecessor checks—we don't relate!
Tidier tests, a rabbit's delight,

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Code changes align with issue #16574 objectives: removing legacy skip tags for version 1.x from YAML REST tests as part of the cleanup effort.
Out of Scope Changes check ✅ Passed All changes are in scope: removals of skip directives for versions 1.4.99 and 1.2.99 from multiple YAML test files match the cleanup objectives of issue #16574.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately and specifically describes the main change: removing legacy v1.x skip tags from YAML REST tests, which is the primary focus of all modified files.
Description check ✅ Passed The description provides a clear summary of the change and references the related issue #16574, but does not provide substantive detail beyond a one-line summary of what was removed.
✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@esl1350 esl1350 changed the title Fix.remove skip tags v1 Remove legacy v1.x skip tags from YAML REST tests Jan 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 6, 2026

❌ Gradle check result for 7582d9a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Copy Markdown
Contributor

@msfroh msfroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

It looks like we have a new flaky test added last week in #19907. I'll restart the build to see if it passes on retry.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 6, 2026

✅ Gradle check result for 7582d9a: SUCCESS

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.28%. Comparing base (d866be8) to head (7582d9a).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #20374      +/-   ##
============================================
- Coverage     73.30%   73.28%   -0.02%     
+ Complexity    71777    71772       -5     
============================================
  Files          5784     5784              
  Lines        328141   328145       +4     
  Branches      47269    47270       +1     
============================================
- Hits         240531   240493      -38     
- Misses        68329    68380      +51     
+ Partials      19281    19272       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cwperks cwperks merged commit b656e0a into opensearch-project:main Jan 7, 2026
42 of 45 checks passed
tanyabti pushed a commit to tanyabti/OpenSearch that referenced this pull request Feb 24, 2026
…#20374)

* start removing tags

Signed-off-by: Elizabeth Liu <esl1350@gmail.com>

* v1 skips

Signed-off-by: Elizabeth Liu <esl1350@gmail.com>

* remove extra blank lines

Signed-off-by: Elizabeth Liu <esl1350@gmail.com>

---------

Signed-off-by: Elizabeth Liu <esl1350@gmail.com>
pradeep-L pushed a commit to pradeep-L/OpenSearch that referenced this pull request Apr 21, 2026
…#20374)

* start removing tags

Signed-off-by: Elizabeth Liu <esl1350@gmail.com>

* v1 skips

Signed-off-by: Elizabeth Liu <esl1350@gmail.com>

* remove extra blank lines

Signed-off-by: Elizabeth Liu <esl1350@gmail.com>

---------

Signed-off-by: Elizabeth Liu <esl1350@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement or improvement to existing feature or request good first issue Good for newcomers Other skip-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Cleanup] Remove legacy skip tags from YAML tests

3 participants