Reuse bucket when reduce terms buckets#20483
Reuse bucket when reduce terms buckets#20483bowenlan-amzn wants to merge 1 commit intoopensearch-project:mainfrom
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
❌ Gradle check result for ae8b2ac: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
ae8b2ac to
ef07406
Compare
|
❌ Gradle check result for ef07406: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
ef07406 to
be081cb
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20483 +/- ##
============================================
+ Coverage 73.25% 73.36% +0.11%
- Complexity 71979 72053 +74
============================================
Files 5796 5796
Lines 329287 329293 +6
Branches 47419 47420 +1
============================================
+ Hits 241203 241575 +372
+ Misses 68759 68401 -358
+ Partials 19325 19317 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This PR is stalled because it has been open for 30 days with no activity. |
Description
When the requested field's cardinality is high, the reduce of term aggregation bucket creation become heavy.
Every cardinality is represented by a bucket. For each reduce, we merge the bucket of same key from multiple responses together, and create a new bucket for that.
This PR tries to reuse the existing bucket from the 1st response by in-place updating the field values, instead of creating one.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.