Skip to content

Migrate KNN serialization interfaces #20513

Closed
ajleong623 wants to merge 2 commits intoopensearch-project:mainfrom
ajleong623:knn-interfaces-serialization
Closed

Migrate KNN serialization interfaces #20513
ajleong623 wants to merge 2 commits intoopensearch-project:mainfrom
ajleong623:knn-interfaces-serialization

Conversation

@ajleong623
Copy link
Copy Markdown
Contributor

@ajleong623 ajleong623 commented Jan 30, 2026

Description

Adds knn interfaces that are shared between knn plugins https://github.com/opensearch-project/k-NN/tree/main and https://github.com/opensearch-project/opensearch-jvector/tree/main to core. This PR focuses on the interfaces relating to serialization logic.

Related Issues

#20050

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Anthony Leong <anthonyleong@Anthonys-MacBook-Air.local>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jan 30, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

✅ Gradle check result for fff514c: SUCCESS

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.36%. Comparing base (fc33a53) to head (fff514c).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #20513      +/-   ##
============================================
+ Coverage     73.19%   73.36%   +0.16%     
- Complexity    71975    72145     +170     
============================================
  Files          5796     5798       +2     
  Lines        329539   329654     +115     
  Branches      47465    47491      +26     
============================================
+ Hits         241220   241842     +622     
+ Misses        69005    68434     -571     
- Partials      19314    19378      +64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Anthony Leong <anthonyleong@Anthonys-MacBook-Air.local>
@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for db4eac6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant