[Benchmark PR Configs] Add id_15 with big5 force intra segment partition strategy#20557
Conversation
📝 WalkthroughWalkthroughThis PR adds a new benchmark configuration entry (id_15) to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
Adding @asimmahmood1 @jainankitk @rishabh6788 |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.github/benchmark-configs.json:
- Around line 245-252: The ADDITIONAL_CONFIG entry currently sets only
search.concurrent_segment_search.partition_strategy but omits the mode,
contradicting the description; update the ADDITIONAL_CONFIG value to include
search.concurrent_segment_search.mode:auto alongside
search.concurrent_segment_search.partition_strategy:force so the configuration
string contains both keys (refer to the ADDITIONAL_CONFIG property and the
existing search.concurrent_segment_search.partition_strategy setting) to match
the "mode as auto" description.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/benchmark-configs.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (19)
- GitHub Check: precommit (21, ubuntu-24.04-arm)
- GitHub Check: precommit (25, windows-latest)
- GitHub Check: precommit (21, windows-latest)
- GitHub Check: precommit (21, windows-2025, true)
- GitHub Check: precommit (21, macos-15-intel)
- GitHub Check: precommit (25, ubuntu-latest)
- GitHub Check: detect-breaking-change
- GitHub Check: precommit (25, ubuntu-24.04-arm)
- GitHub Check: precommit (25, macos-15-intel)
- GitHub Check: precommit (25, macos-15)
- GitHub Check: precommit (21, macos-15)
- GitHub Check: precommit (21, ubuntu-latest)
- GitHub Check: assemble (21, ubuntu-latest)
- GitHub Check: assemble (25, windows-latest)
- GitHub Check: assemble (21, windows-latest)
- GitHub Check: assemble (25, ubuntu-latest)
- GitHub Check: assemble (21, ubuntu-24.04-arm)
- GitHub Check: assemble (25, ubuntu-24.04-arm)
- GitHub Check: Analyze (java)
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
|
Thanks @asimmahmood1, @jainankitk are we good with this change? |
sandeshkr419
left a comment
There was a problem hiding this comment.
@prudhvigodithi Let's add a changelog as well. Rest LGTM!
In past for these changes we usually skip the changelog, but the unresolved comments was preventing this PR from merged. |
ee0a9be
into
opensearch-project:main
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Description
id_15withbig5force intra segment partition strategy."ADDITIONAL_CONFIG": "search.concurrent_segment_search.partition_strategy:force",balancedandforcepartition strategy.Related Issues
Part of #20202
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.