Skip to content

Fix flaky testPutGlobalV2TemplateWhichProvidesContextWithContextDisabled #20640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrross merged 1 commit into from
Feb 17, 2026
Merged

Fix flaky testPutGlobalV2TemplateWhichProvidesContextWithContextDisabled #20640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 39 additions & 35 deletions server/src/test/java/org/opensearch/cluster/metadata/MetadataIndexTemplateServiceTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
import org.opensearch.common.settings.Settings;
import org.opensearch.common.settings.SettingsException;
import org.opensearch.common.unit.TimeValue;
import org.opensearch.common.util.FeatureFlags;
import org.opensearch.common.util.concurrent.ThreadContext;
import org.opensearch.common.xcontent.LoggingDeprecationHandler;
import org.opensearch.common.xcontent.XContentFactory;
Expand Down Expand Up @@ -797,42 +798,45 @@ public void onFailure(Exception e) {
}

public void testPutGlobalV2TemplateWhichProvidesContextWithContextDisabled() throws Exception {
MetadataIndexTemplateService metadataIndexTemplateService = getMetadataIndexTemplateService();
ComposableIndexTemplate globalIndexTemplate = new ComposableIndexTemplate(
List.of("*"),
null,
List.of(),
null,
null,
null,
null,
new Context("any")
);
InvalidIndexTemplateException ex = expectThrows(
InvalidIndexTemplateException.class,
() -> metadataIndexTemplateService.putIndexTemplateV2(
"testing",
true,
"template-referencing-context-as-ct",
TimeValue.timeValueSeconds(30L),
globalIndexTemplate,
new ActionListener<AcknowledgedResponse>() {
@Override
public void onResponse(AcknowledgedResponse response) {
fail("the listener should not be invoked as validation should fail");
}

@Override
public void onFailure(Exception e) {
fail("the listener should not be invoked as validation should fail");
// Explicitly disable the FF
FeatureFlags.TestUtils.with(APPLICATION_BASED_CONFIGURATION_TEMPLATES, false, () -> {
MetadataIndexTemplateService metadataIndexTemplateService = getMetadataIndexTemplateService();
ComposableIndexTemplate globalIndexTemplate = new ComposableIndexTemplate(
List.of("*"),
null,
List.of(),
null,
null,
null,
null,
new Context("any")
);
InvalidIndexTemplateException ex = expectThrows(
InvalidIndexTemplateException.class,
() -> metadataIndexTemplateService.putIndexTemplateV2(
"testing",
true,
"template-referencing-context-as-ct",
TimeValue.timeValueSeconds(30L),
globalIndexTemplate,
new ActionListener<AcknowledgedResponse>() {
@Override
public void onResponse(AcknowledgedResponse response) {
fail("the listener should not be invoked as validation should fail");
}

@Override
public void onFailure(Exception e) {
fail("the listener should not be invoked as validation should fail");
}
}
}
)
);
assertTrue(
"Invalid exception message." + ex.getMessage(),
ex.getMessage().contains("specifies a context which cannot be used without enabling")
);
)
);
assertTrue(
"Invalid exception message." + ex.getMessage(),
ex.getMessage().contains("specifies a context which cannot be used without enabling")
);
});
}

@LockFeatureFlag(APPLICATION_BASED_CONFIGURATION_TEMPLATES)
Expand Down
Loading