Skip to content

Fix flaky slowlog test #20726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jainankitk merged 1 commit into from
Mar 4, 2026
Merged

Fix flaky slowlog test #20726

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions server/src/test/java/org/opensearch/action/search/SearchRequestSlowLogTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,27 +88,25 @@ public static void cleanup() {

public void testMultipleSlowLoggersUseSingleLog4jLogger() {
LoggerContext context = (LoggerContext) LogManager.getContext(false);
String loggerName = SearchRequestSlowLog.CLUSTER_SEARCH_REQUEST_SLOWLOG_PREFIX + ".SearchRequestSlowLog";

new MockSearchPhaseContext(1);
ClusterService clusterService1 = ClusterServiceUtils.createClusterService(
Settings.EMPTY,
new ClusterSettings(Settings.EMPTY, ClusterSettings.BUILT_IN_CLUSTER_SETTINGS),
null
);
new SearchRequestSlowLog(clusterService1);
int numberOfLoggersBefore = context.getLoggers().size();
Logger logger1 = context.getLogger(loggerName);

new MockSearchPhaseContext(1);
ClusterService clusterService2 = ClusterServiceUtils.createClusterService(
Settings.EMPTY,
new ClusterSettings(Settings.EMPTY, ClusterSettings.BUILT_IN_CLUSTER_SETTINGS),
null
);
new SearchRequestOperationsCompositeListenerFactory();
new SearchRequestSlowLog(clusterService2);
Logger logger2 = context.getLogger(loggerName);

int numberOfLoggersAfter = context.getLoggers().size();
assertThat(numberOfLoggersAfter, equalTo(numberOfLoggersBefore));
assertSame(logger1, logger2);
}

public void testOnRequestEnd() {
Expand Down
Loading