delegate getMin/getMax methods for ExitableTerms#20775

Merged

bugmakerrrrrr merged 3 commits intoopensearch-project:mainfrom

HUSTERGS:delegate_terms

Mar 10, 2026

Contributor

HUSTERGS commented Mar 4, 2026

Description

ExitableTerms should delegate getMin/getMax methods, or else the getMax() from

OpenSearch/server/src/main/java/org/opensearch/search/sort/FieldSortBuilder.java

Lines 660 to 664 in 4ae7ff3

    
           Terms terms = MultiTerms.getTerms(reader, fieldType.name()); 
        
           if (terms == null) { 
        
               return null; 
        
           } 
        
           return terms.getMin() != null ? new MinAndMax<>(terms.getMin(), terms.getMax()) : null;

will call the default implementation, which is a slow path, and will get a flamegraph like below

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

Functionality includes testing.
API changes companion pull request created, if applicable.
Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

HUSTERGS requested review from a team, Bukhtawar, CEHENKLE, Rishikesh1159, anasalkouz, andrross, ashking94, cwperks, dbwiddis, gbbafna, jed326, kotwanikunal, mch2, msfroh, owaiskazi19, reta, sachinpkale, saratvemulapalli, shwetathareja and sohami as code owners

March 4, 2026 15:58

Contributor

github-actions bot commented Mar 4, 2026 •

edited

Loading

PR Reviewer Guide 🔍

(Review updated until commit `48e447d`)

Here are some key observations to aid the review process:

🧪 No relevant tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ Recommended focus areas for review Formatting Error The CHANGELOG entry has a double dash prefix (`- -`) instead of a single dash (`-`), which is a formatting mistake that should be corrected. - - Delegate getMin/getMax methods for ExitableTerms ([#20775](https://github.com/opensearch-project/OpenSearch/pull/20775))


          delegate getMin/getMax for ExitableTerms

2e85d39

Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>

HUSTERGS force-pushed the delegate_terms branch from e21c86b to 2e85d39 Compare

March 4, 2026 16:01

Contributor

github-actions bot commented Mar 4, 2026

Persistent review updated to latest commit 2e85d39

Contributor

github-actions bot commented Mar 4, 2026

❌ Gradle check result for 2e85d39: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

bugmakerrrrrr approved these changes

View reviewed changes

Contributor

bugmakerrrrrr left a comment

LGTM

Contributor

github-actions bot commented Mar 5, 2026

❌ Gradle check result for 2e85d39: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Contributor

github-actions bot commented Mar 5, 2026

❌ Gradle check result for 2e85d39: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Contributor

github-actions bot commented Mar 5, 2026

❌ Gradle check result for 2e85d39: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Contributor

github-actions bot commented Mar 5, 2026

❌ Gradle check result for 2e85d39: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Contributor

github-actions bot commented Mar 6, 2026

❌ Gradle check result for 48e447d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Contributor

github-actions bot commented Mar 6, 2026

❌ Gradle check result for 48e447d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Contributor

github-actions bot commented Mar 6, 2026

❌ Gradle check result for 48e447d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

HUSTERGS closed this

HUSTERGS reopened this

Contributor

github-actions bot commented Mar 9, 2026

Persistent review updated to latest commit 48e447d

Contributor

github-actions bot commented Mar 9, 2026

❌ Gradle check result for 48e447d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

HUSTERGS closed this

HUSTERGS reopened this

Contributor

github-actions bot commented Mar 9, 2026

Persistent review updated to latest commit 48e447d

Contributor

github-actions bot commented Mar 9, 2026

❌ Gradle check result for 48e447d: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

HUSTERGS closed this

HUSTERGS reopened this

Contributor

github-actions bot commented Mar 9, 2026

Persistent review updated to latest commit 48e447d

Contributor

github-actions bot commented Mar 9, 2026

❌ Gradle check result for 48e447d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

HUSTERGS closed this

HUSTERGS reopened this

Contributor

github-actions bot commented Mar 9, 2026

Persistent review updated to latest commit 48e447d

Contributor

github-actions bot commented Mar 9, 2026

❌ Gradle check result for 48e447d: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Mar 9, 2026

[AUTOCUT] Gradle Check Flaky Test Report for AzureBlobStoreRepositoryTests #14291

Open

[AUTOCUT] Gradle Check Flaky Test Report for FullRollingRestartIT #18490

Open

[AUTOCUT] Gradle Check Flaky Test Report for RestoreShallowSnapshotV2IT #16658

Open

[AUTOCUT] Gradle Check Flaky Test Report for ShardsLimitAllocationDeciderIT #19726

Closed

[AUTOCUT] Gradle Check Flaky Test Report for RemoteRestoreSnapshotIT #14324

Open

[AUTOCUT] Gradle Check Flaky Test Report for RecoveryWhileUnderLoadIT #14509

Open

HUSTERGS closed this

HUSTERGS reopened this

Contributor

github-actions bot commented Mar 10, 2026

Persistent review updated to latest commit 48e447d

Contributor

github-actions bot commented Mar 10, 2026

✅ Gradle check result for 48e447d: SUCCESS

bugmakerrrrrr merged commit dcbdefa into opensearch-project:main

176 of 229 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bugmakerrrrrr bugmakerrrrrr approved these changes

anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

andrross Awaiting requested review from andrross andrross is a code owner

ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

cwperks Awaiting requested review from cwperks cwperks is a code owner

dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

jed326 Awaiting requested review from jed326 jed326 is a code owner

kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

mch2 Awaiting requested review from mch2 mch2 is a code owner

msfroh Awaiting requested review from msfroh msfroh is a code owner

owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

reta Awaiting requested review from reta reta is a code owner

Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

sohami Awaiting requested review from sohami sohami is a code owner

Labels

None yet