Lazy init stored field reader in SourceLookup#20827
Lazy init stored field reader in SourceLookup#20827rishabhmaurya merged 3 commits intoopensearch-project:mainfrom
Conversation
PR Reviewer Guide 🔍(Review updated until commit c575d0a)Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Latest suggestions up to c575d0a Explore these optional code suggestions:
Previous suggestionsSuggestions up to commit 7c09502
Suggestions up to commit 7c09502
Suggestions up to commit 641f458
Suggestions up to commit 641f458
Suggestions up to commit 641f458
|
|
❌ Gradle check result for 33e3aeb: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
33e3aeb to
7536dd6
Compare
|
Persistent review updated to latest commit 7536dd6 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20827 +/- ##
============================================
- Coverage 73.24% 73.22% -0.02%
+ Complexity 72510 72474 -36
============================================
Files 5819 5819
Lines 331373 331372 -1
Branches 47882 47883 +1
============================================
- Hits 242707 242663 -44
- Misses 69201 69202 +1
- Partials 19465 19507 +42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7536dd6 to
9be78fa
Compare
|
Persistent review updated to latest commit 9be78fa |
|
Persistent review updated to latest commit a5bfa82 |
33066f4 to
641f458
Compare
|
Persistent review updated to latest commit 641f458 |
|
❌ Gradle check result for 641f458: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Persistent review updated to latest commit 641f458 |
|
❌ Gradle check result for 641f458: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Persistent review updated to latest commit 641f458 |
|
❌ Gradle check result for 641f458: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Persistent review updated to latest commit 7c09502 |
|
Persistent review updated to latest commit 7c09502 |
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> revert vcs change Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
7c09502 to
c575d0a
Compare
|
Persistent review updated to latest commit c575d0a |
|
❕ Gradle check result for c575d0a: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Description
Defers
getMergeInstance()fromsetSegmentAndDocument()toloadSourceIfNeeded(). Scripts that don't read_sourcenever trigger thegetMergeInstance()path:Related Issues
Resolves #20933
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.