Skip to content

Disable concurrent search for filter duplicates in significant_text #20857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrross merged 1 commit into from
Mar 17, 2026
Merged

Disable concurrent search for filter duplicates in significant_text #20857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
- Use env variable (OPENSEARCH_FIPS_MODE) to enable opensearch to run in FIPS enforced mode instead of checking for existence of bcFIPS jars ([#20625](https://github.com/opensearch-project/OpenSearch/pull/20625))
- Update streaming flag to use search request context ([#20530](https://github.com/opensearch-project/OpenSearch/pull/20530))
- Move pull-based ingestion classes from experimental to publicAPI ([#20704](https://github.com/opensearch-project/OpenSearch/pull/20704))
- Disable concurrent search for filter duplicates in significant_text ([#20857](https://github.com/opensearch-project/OpenSearch/pull/20857))

### Fixed
- Fix `AutoForceMergeMetrics` silently dropping tags due to unreassigned `addTag()` return value ([#20788](https://github.com/opensearch-project/OpenSearch/pull/20788))
Expand Down
5 changes: 4 additions & 1 deletion ...ava/org/opensearch/search/aggregations/bucket/terms/SignificantTextAggregatorFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,9 @@ public void close() {

@Override
protected boolean supportsConcurrentSegmentSearch() {
return true;
// The underlying structured used to find duplicate byte sequences (DuplicateByteSequenceSpotter)
Copy link
Copy Markdown
Contributor

@sohami sohami Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is unclear why DuplicateByteSequenceSpotter needs to be threadsafe for inter-segment concurrent search. I see it being created at per leaf (or segment) and owning ord combination here

// is stateful and not thread-safe, so disable concurrent search if this particular feature is
// being used.
return filterDuplicateText == false;
}
}
Loading