Add static method to expose STRICT_EXPAND_OPEN_HIDDEN_FORBID_CLOSED index option#20980
Conversation
PR Reviewer Guide 🔍(Review updated until commit 52e8bad)Here are some key observations to aid the review process:
|
|
To admins: I am not sure about the |
|
Persistent review updated to latest commit 0cad5ac |
PR Code Suggestions ✨Explore these optional code suggestions:
|
…ndex option IndicesOptions class provide static methods to access all index options but this one. It seems like it has been forgotten. This PR addresses this which makes it possible to document this option the same way other index options are documented. Closes: opensearch-project#20963 Signed-off-by: Lukáš Vlček <lukas.vlcek@gmail.com>
|
Persistent review updated to latest commit 52e8bad |
|
CHANGELOG.md is a bit messed up at this point. I am adding an extra empty line after my new entry but notice that there is already one extra empty line in the list of enhancements. I do not want to put my record into that extra empty line because I think that waould make merging more conflicting for others. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20980 +/- ##
============================================
- Coverage 73.28% 73.26% -0.03%
- Complexity 72490 72509 +19
============================================
Files 5819 5819
Lines 331398 331399 +1
Branches 47887 47887
============================================
- Hits 242875 242794 -81
- Misses 68984 69073 +89
+ Partials 19539 19532 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
IMO |
…ndex option (opensearch-project#20980) IndicesOptions class provide static methods to access all index options but this one. It seems like it has been forgotten. This PR addresses this which makes it possible to document this option the same way other index options are documented. Closes: opensearch-project#20963 Signed-off-by: Lukáš Vlček <lukas.vlcek@gmail.com> Signed-off-by: Gagan Dhakrey <gagandhakrey@Gagans-MacBook-Pro.local>
…ndex option (opensearch-project#20980) IndicesOptions class provide static methods to access all index options but this one. It seems like it has been forgotten. This PR addresses this which makes it possible to document this option the same way other index options are documented. Closes: opensearch-project#20963 Signed-off-by: Lukáš Vlček <lukas.vlcek@gmail.com> Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com>
…ndex option (opensearch-project#20980) IndicesOptions class provide static methods to access all index options but this one. It seems like it has been forgotten. This PR addresses this which makes it possible to document this option the same way other index options are documented. Closes: opensearch-project#20963 Signed-off-by: Lukáš Vlček <lukas.vlcek@gmail.com>
Description
IndicesOptions class provide static methods to access all index options but this one. It seems like it has been forgotten. This PR addresses this which makes it possible to document this option the same way other index options are documented.
Important question: Does this PR changes public API in any way that needs to be documented or annotated?
I also changed one test to use access method instead of directly access the constant instance. See #20981 for more general discussion about this.
Related Issues
Closes: #20963
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.