Skip to content

Updating the FieldMappers to insert call addField of DocumentInput#21001

Draft
darjisagar7 wants to merge 1 commit intoopensearch-project:mainfrom
darjisagar7:DocumentInput
Draft

Updating the FieldMappers to insert call addField of DocumentInput#21001
darjisagar7 wants to merge 1 commit intoopensearch-project:mainfrom
darjisagar7:DocumentInput

Conversation

@darjisagar7
Copy link
Copy Markdown

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Copy Markdown
Contributor

Failed to generate code suggestions for PR

@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 7f26163: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

PR Code Analyzer ❗

AI-powered 'Code-Diff-Analyzer' found issues on commit 80f72cd.

PathLineSeverityDescription
modules/parent-join/src/main/java/org/opensearch/join/mapper/ParentJoinFieldMapper.java430lowThe `context.path().remove()` call is omitted from the pluggable-dataformat branch. In the original code this cleanup was always executed after adding fields, but in the refactored block it only runs in the legacy `else` path. When the feature is enabled, the path state is not cleaned up, which could cause subtle document-parsing state corruption. This appears to be an unintentional omission rather than malicious, but is worth investigation.

The table above displays the top 10 most important findings.

Total: 1 | Critical: 0 | High: 0 | Medium: 0 | Low: 1


Pull Requests Author(s): Please update your Pull Request according to the report above.

Repository Maintainer(s): You can bypass diff analyzer by adding label skip-diff-analyzer after reviewing the changes carefully, then re-run failed actions. To re-enable the analyzer, remove the label, then re-run all actions.


⚠️ Note: The Code-Diff-Analyzer helps protect against potentially harmful code patterns. Please ensure you have thoroughly reviewed the changes beforehand.

Thanks.

@github-actions
Copy link
Copy Markdown
Contributor

Failed to generate code suggestions for PR

@github-actions
Copy link
Copy Markdown
Contributor

Failed to generate code suggestions for PR

@github-actions
Copy link
Copy Markdown
Contributor

✅ Gradle check result for 93426fa: SUCCESS

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

❌ Patch coverage is 81.75182% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.13%. Comparing base (aeed2c7) to head (2fc592f).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...h/index/mapper/ICUCollationKeywordFieldMapper.java 55.55% 1 Missing and 3 partials ⚠️
.../opensearch/index/mapper/size/SizeFieldMapper.java 0.00% 3 Missing ⚠️
.../org/opensearch/index/mapper/RangeFieldMapper.java 40.00% 1 Missing and 2 partials ⚠️
...earch/index/mapper/SearchAsYouTypeFieldMapper.java 75.00% 1 Missing and 1 partial ⚠️
...rg/opensearch/join/mapper/ParentIdFieldMapper.java 60.00% 1 Missing and 1 partial ⚠️
.../opensearch/join/mapper/ParentJoinFieldMapper.java 60.00% 1 Missing and 1 partial ⚠️
.../java/org/opensearch/index/mapper/FieldMapper.java 75.00% 1 Missing and 1 partial ⚠️
...pensearch/index/mapper/ScaledFloatFieldMapper.java 87.50% 0 Missing and 1 partial ⚠️
...rg/opensearch/index/mapper/BooleanFieldMapper.java 88.88% 0 Missing and 1 partial ⚠️
...a/org/opensearch/index/mapper/DateFieldMapper.java 91.66% 0 Missing and 1 partial ⚠️
... and 4 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #21001      +/-   ##
============================================
- Coverage     73.22%   73.13%   -0.09%     
+ Complexity    72601    72565      -36     
============================================
  Files          5848     5848              
  Lines        331970   332035      +65     
  Branches      47948    47968      +20     
============================================
- Hits         243075   242848     -227     
- Misses        69390    69733     +343     
+ Partials      19505    19454      -51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

1. Introducing FeatureFlag and Index Setting for pluggable dataformat feature.
2. Updating the FieldMappers to insert fields in DocumentInput for Multi Format Engine

Signed-off-by: Sagar Darji <darsaga@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

Failed to generate code suggestions for PR

@github-actions
Copy link
Copy Markdown
Contributor

✅ Gradle check result for 2fc592f: SUCCESS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant