Change access modifier for convert::FieldValueFetcher to allow other Field Fetchers to override the method#21005
Open
neetikasinghal wants to merge 2 commits intoopensearch-project:mainfrom
Open
Conversation
…Field Fetchers to override the method Signed-off-by: Neetika Singhal <neetiks@amazon.com>
neetikasinghal
requested review from
a team,
Bukhtawar,
CEHENKLE,
Rishikesh1159,
anasalkouz,
andrross,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
github-actions
bot
added
the
dependencies
Contributor
|
Failed to generate code suggestions for PR |
Contributor
|
❕ Gradle check result for 9bd6061: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21005 +/- ##
============================================
- Coverage 73.26% 73.21% -0.05%
- Complexity 72743 72755 +12
============================================
Files 5862 5862
Lines 332558 332558
Branches 48010 48010
============================================
- Hits 243643 243479 -164
- Misses 69343 69605 +262
+ Partials 19572 19474 -98 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Failed to generate code suggestions for PR |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related PR: opensearch-project/k-NN#3209
Related Issues
Resolves opensearch-project/k-NN#3058
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.