Skip to content

[Backport 3.5] Check for -Dorg.bouncycastle.fips.approved_only in testclusters to run with FIPS enforcement#21006

Merged
andrross merged 1 commit into
3.5from
backport/backport-20685-to-3.5
Mar 26, 2026
Merged

[Backport 3.5] Check for -Dorg.bouncycastle.fips.approved_only in testclusters to run with FIPS enforcement#21006
andrross merged 1 commit into
3.5from
backport/backport-20685-to-3.5

Conversation

@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

Backport bc98ec8 from #20685.

…n with FIPS enforcement (#20685)

* Also check for -Dorg.bouncycastle.fips.approved_only in testclusters to enforce running with FIPS enforcement

Signed-off-by: Craig Perkins <craig5008@gmail.com>
Co-authored-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit bc98ec8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot Bot requested a review from a team as a code owner March 26, 2026 19:16
@github-actions
Copy link
Copy Markdown
Contributor

PR Code Analyzer ❗

AI-powered 'Code-Diff-Analyzer' found issues on commit 0fcf9ca.

PathLineSeverityDescription
buildSrc/src/main/java/org/opensearch/gradle/testclusters/OpenSearchNode.java552mediumSecurity enforcement weakened: the keystore password requirement for FIPS mode was narrowed from `isInFipsMode()` to `isInFipsApprovedOnlyMode()`. This means test clusters running in standard FIPS mode (without the `org.bouncycastle.fips.approved_only` JVM property) can now start without a keystore password — bypassing a previously mandatory security check. While the distinction between FIPS mode and FIPS approved-only mode can be legitimate, this change silently downgrades a FIPS enforcement gate and warrants scrutiny to confirm intent.

The table above displays the top 10 most important findings.

Total: 1 | Critical: 0 | High: 0 | Medium: 1 | Low: 0


Pull Requests Author(s): Please update your Pull Request according to the report above.

Repository Maintainer(s): You can bypass diff analyzer by adding label skip-diff-analyzer after reviewing the changes carefully, then re-run failed actions. To re-enable the analyzer, remove the label, then re-run all actions.


⚠️ Note: The Code-Diff-Analyzer helps protect against potentially harmful code patterns. Please ensure you have thoroughly reviewed the changes beforehand.

Thanks.

@andrross andrross added skip-changelog skip-diff-analyzer Maintainer to skip code-diff-analyzer check, after reviewing issues in AI analysis. labels Mar 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

✅ Gradle check result for 0fcf9ca: SUCCESS

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 26, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.25%. Comparing base (c8335ed) to head (0fcf9ca).
⚠️ Report is 6 commits behind head on 3.5.

Files with missing lines Patch % Lines
...va/org/opensearch/gradle/info/FipsBuildParams.java 0.00% 1 Missing ⚠️
...opensearch/gradle/testclusters/OpenSearchNode.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.5   #21006      +/-   ##
============================================
+ Coverage     73.18%   73.25%   +0.07%     
- Complexity    71865    71911      +46     
============================================
  Files          5782     5782              
  Lines        329125   329128       +3     
  Branches      47451    47451              
============================================
+ Hits         240854   241101     +247     
+ Misses        68955    68633     -322     
- Partials      19316    19394      +78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrross andrross merged commit 1f78bac into 3.5 Mar 26, 2026
43 of 47 checks passed
@andrross andrross deleted the backport/backport-20685-to-3.5 branch March 26, 2026 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog skip-diff-analyzer Maintainer to skip code-diff-analyzer check, after reviewing issues in AI analysis.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant