Support Jackson 3.x release line by reta · Pull Request #21029 · opensearch-project/OpenSearch

reta · 2026-03-28T14:34:46Z

Description

Support Jackson 3.x release line. The change does a few things:

the OpenSearch Core switches to Jackson 3.x release line at once (x-content, etc..)
the OpenSearch server module will continue to bundle Jackson 2.x artifacts (along with Jackson 3.x) to not break existing plugins
once all plugins switch to Jackson 3.x, the server could drop Jackson 2.x artifacts bundling

Related Issues

Closes #19597

Check List

Functionality includes testing.
API changes companion pull request created, if applicable.
Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2026-03-28T14:36:22Z

Failed to generate code suggestions for PR

github-actions · 2026-03-28T14:57:49Z

❌ Gradle check result for 08afabb: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2026-03-28T15:23:52Z

PR Code Analyzer ❗

AI-powered 'Code-Diff-Analyzer' found issues on commit 3bc6e02.

Path	Line	Severity	Description
server/src/main/resources/org/opensearch/bootstrap/security.policy	113	medium	New security policy grant gives jackson3-core broad network socket permissions ('java.net.SocketPermission "*", "connect,resolve"'). While this mirrors the existing grant for jackson-core 2.x and appears justified for Unix domain socket support, granting outbound network access to a JSON parsing library from a new/different group ID (tools.jackson vs com.fasterxml.jackson) warrants review to confirm the new artifact is the legitimate Jackson 3.x release and not a substituted malicious dependency.
gradle/libs.versions.toml	14	low	Multiple new SHA1 hashes are introduced for Jackson 3.x artifacts under a new Maven group ID (tools.jackson.core/tools.jackson.dataformat). These cannot be verified inline; if any hash was manipulated to match a compromised JAR, it would constitute a supply chain attack. The hashes should be independently verified against the official Maven Central repository for jackson-core 3.1.0, jackson-dataformat-smile/yaml/cbor 3.1.0, snakeyaml 2.6, and snakeyaml-engine 3.0.1.

The table above displays the top 10 most important findings.

Total: 2 | Critical: 0 | High: 0 | Medium: 1 | Low: 1

Pull Requests Author(s): Please update your Pull Request according to the report above.

Repository Maintainer(s): You can bypass diff analyzer by adding label skip-diff-analyzer after reviewing the changes carefully, then re-run failed actions. To re-enable the analyzer, remove the label, then re-run all actions.

⚠️ Note: The Code-Diff-Analyzer helps protect against potentially harmful code patterns. Please ensure you have thoroughly reviewed the changes beforehand.

Thanks.

github-actions · 2026-03-28T16:22:59Z

Failed to generate code suggestions for PR

github-actions · 2026-03-28T16:36:26Z

❌ Gradle check result for 8f7c773: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2026-03-30T16:50:08Z

Failed to generate code suggestions for PR

github-actions · 2026-03-30T17:05:46Z

❌ Gradle check result for dc8261d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2026-03-30T19:31:51Z

Failed to generate code suggestions for PR

github-actions · 2026-03-30T21:00:46Z

✅ Gradle check result for 999e868: SUCCESS

github-actions · 2026-03-30T23:38:19Z

Persistent review updated to latest commit c4ee6f8

github-actions · 2026-03-31T01:06:34Z

✅ Gradle check result for c4ee6f8: SUCCESS

github-actions · 2026-03-31T01:17:10Z

Persistent review updated to latest commit f29e4a7

github-actions · 2026-03-31T02:04:28Z

❌ Gradle check result for f29e4a7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2026-03-31T11:45:53Z

Persistent review updated to latest commit c52b5b2

github-actions · 2026-03-31T13:16:51Z

❕ Gradle check result for c52b5b2: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

github-actions · 2026-03-31T14:20:45Z

Persistent review updated to latest commit bd926ae

github-actions · 2026-03-31T15:55:38Z

✅ Gradle check result for bd926ae: SUCCESS

github-actions · 2026-03-31T16:31:57Z

Persistent review updated to latest commit 3ccda43

github-actions · 2026-03-31T17:58:18Z

✅ Gradle check result for 3ccda43: SUCCESS

Signed-off-by: Andriy Redko <drreta@gmail.com>

github-actions · 2026-03-31T21:18:35Z

Persistent review updated to latest commit e361206

reta · 2026-03-31T21:46:03Z

libs/core/src/main/java/org/opensearch/core/xcontent/XContentBuilder.java

+     * the generator instantiation till the first usage.
+     */
+    private XContentGenerator generatorInstance() throws IOException {
+        if (generator == null) {


@andrross @cwperks this is probably the most impactful change in the whole pull request, making generator initialization lazy. I initially overthought it and used volatile + double check locking but looking closely, I have not found the evidence XContentBuilder instances are shared across threads (quite expected), simple null check should be sufficient.

github-actions · 2026-03-31T22:45:50Z

✅ Gradle check result for e361206: SUCCESS

andrross · 2026-04-01T01:41:31Z

libs/core/src/main/java/org/opensearch/core/xcontent/XContentBuilder.java


    public XContentBuilder prettyPrint() {
-        generator.usePrettyPrint();
+        this.prettyPrint = true;


So calling this method (and some others) will have no effect if generatorInstance() has already been invoked on this instance? Is this behavior change going to be impactful? Should these method throw if the generator instance has already been constructed?

reta requested review from a team, Bukhtawar, CEHENKLE, Rishikesh1159, anasalkouz, andrross, ashking94, cwperks, dbwiddis, gbbafna, jed326, kotwanikunal, mch2, msfroh, owaiskazi19, sachinpkale, saratvemulapalli, shwetathareja and sohami as code owners March 28, 2026 14:34

github-actions bot added enhancement Enhancement or improvement to existing feature or request Libraries Lucene Upgrades and Libraries, Any 3rd party library that Core depends on, ex: nebula; team is respo v3.7.0 Issues and PRs related to version 3.7.0 labels Mar 28, 2026

reta force-pushed the issue-19597 branch from 08afabb to 3d184d9 Compare March 28, 2026 15:22

reta force-pushed the issue-19597 branch from 3d184d9 to 8f7c773 Compare March 28, 2026 16:20

reta force-pushed the issue-19597 branch from 8f7c773 to 3bc6e02 Compare March 28, 2026 17:15

reta force-pushed the issue-19597 branch from c388b12 to dc8261d Compare March 30, 2026 16:48

reta force-pushed the issue-19597 branch from dc8261d to 999e868 Compare March 30, 2026 19:30

reta force-pushed the issue-19597 branch from 999e868 to c4ee6f8 Compare March 30, 2026 23:37

reta force-pushed the issue-19597 branch from c4ee6f8 to f29e4a7 Compare March 31, 2026 01:15

This was referenced Mar 31, 2026

[AUTOCUT] Gradle Check Flaky Test Report for IndexShardTests #14321

Open

[AUTOCUT] Gradle Check Flaky Test Report for NRTReplicationEngineTests #15817

Open

reta force-pushed the issue-19597 branch from f29e4a7 to c52b5b2 Compare March 31, 2026 11:44

reta force-pushed the issue-19597 branch from c52b5b2 to bd926ae Compare March 31, 2026 14:19

opensearch-ci-bot mentioned this pull request Mar 31, 2026

[AUTOCUT] Gradle Check Flaky Test Report for AzureBlobStoreRepositoryTests #14291

Open

reta force-pushed the issue-19597 branch from bd926ae to 3ccda43 Compare March 31, 2026 16:30

Support Jackson 3.x release line

e361206

Signed-off-by: Andriy Redko <drreta@gmail.com>

reta force-pushed the issue-19597 branch from 3ccda43 to e361206 Compare March 31, 2026 21:17

reta commented Mar 31, 2026

View reviewed changes

andrross reviewed Apr 1, 2026

View reviewed changes

Conversation

reta commented Mar 28, 2026

Description

Related Issues

Check List

Uh oh!

github-actions bot commented Mar 28, 2026

Uh oh!

github-actions bot commented Mar 28, 2026

Uh oh!

github-actions bot commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Code Analyzer ❗

Uh oh!

github-actions bot commented Mar 28, 2026

Uh oh!

github-actions bot commented Mar 28, 2026

Uh oh!

github-actions bot commented Mar 30, 2026

Uh oh!

github-actions bot commented Mar 30, 2026

Uh oh!

github-actions bot commented Mar 30, 2026

Uh oh!

github-actions bot commented Mar 30, 2026

Uh oh!

github-actions bot commented Mar 30, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

reta Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

andrross Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Mar 28, 2026 •

edited

Loading

reta Mar 31, 2026 •

edited

Loading