Adjust version after backport to 1.3.0.0 by penghuo · Pull Request #2147 · opensearch-project/OpenSearch

penghuo · 2022-02-17T01:14:53Z

Description

Adjust version to 1.3.0.0 after backport PR [Backport 1.x] Support first and last parameter for missing bucket ordering in composite aggregation #2049 merged.
Test Passed.
2.1. ./gradlew precommit
2.2../gradlew ':server:test' -Dtests.iters=100 --tests "org.opensearch.search.aggregations.bucket.composite.CompositeAggregatorTests"
2.3../gradlew ':qa:mixed-cluster:v1.3.0#mixedClusterTest' --tests "org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT"
Add bwc test for missing_order.

Issues Resolved

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peng Huo <penghuo@gmail.com>

opensearch-ci-bot · 2022-02-17T01:16:03Z

Can one of the admins verify this patch?

opensearch-ci-bot · 2022-02-17T02:01:51Z

❌ Gradle Check failure ec9b678
Log 2478

Reports 2478

andrross · 2022-02-17T14:16:54Z

Build failure:

| Errors during downloading metadata for repository 'baseos':
|   - Curl error (28): Timeout was reached for http://vault.centos.org/centos/8/BaseOS/x86_64/os/repodata/repomd.xml [Connection timed out after 30001 milliseconds]
|   - Curl error (28): Timeout was reached for http://vault.centos.org/centos/8/BaseOS/x86_64/os/repodata/repomd.xml [Operation too slow. Less than 1000 bytes/sec transferred the last 30 seconds]
|   - Curl error (28): Timeout was reached for https://vault.centos.org/centos/8/BaseOS/x86_64/os/repodata/repomd.xml [Operation timed out after 30000 milliseconds with 0 out of 0 bytes received]
| Error: Failed to download metadata for repo 'baseos': Cannot download repomd.xml: Cannot download repodata/repomd.xml: All mirrors were tried

andrross · 2022-02-17T14:17:02Z

start gradle check

opensearch-ci-bot · 2022-02-17T14:47:26Z

❌ Gradle Check failure ec9b678
Log 2494

Reports 2494

andrross · 2022-02-17T16:16:31Z

REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.cluster.ClusterHealthIT.testHealthOnMasterFailover" -Dtests.seed=B224EE00DAD31419 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=sr-RS -Dtests.timezone=Europe/Istanbul -Druntime.java=17

org.opensearch.cluster.ClusterHealthIT > testHealthOnMasterFailover FAILED
    java.lang.AssertionError: expected same:<YELLOW> was not:<GREEN>
        at __randomizedtesting.SeedInfo.seed([B224EE00DAD31419:2CCBC12DD93908FF]:0)
        at org.junit.Assert.fail(Assert.java:89)
        at org.junit.Assert.failNotSame(Assert.java:829)
        at org.junit.Assert.assertSame(Assert.java:772)
        at org.junit.Assert.assertSame(Assert.java:783)
        at org.opensearch.cluster.ClusterHealthIT.testHealthOnMasterFailover(ClusterHealthIT.java:393)

andrross · 2022-02-17T16:16:39Z

start gradle check

mattweber · 2022-02-17T16:19:43Z

@andrross fail from #1828?

opensearch-ci-bot · 2022-02-17T16:47:00Z

❌ Gradle Check failure ec9b678
Log 2498

Reports 2498

andrross · 2022-02-17T16:53:48Z

@penghuo seems like maybe there is still a bug here?

REPRODUCE WITH: ./gradlew ':rest-api-spec:yamlRestTest' --tests "org.opensearch.test.rest.ClientYamlTestSuiteIT" -Dtests.method="test {p0=search.aggregation/20_terms/string profiler via global ordinals}" -Dtests.seed=DA2B6434DB8440A7 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.local
e=nn-NO -Dtests.timezone=Asia/Ulaanbaatar -Druntime.java=17

org.opensearch.test.rest.ClientYamlTestSuiteIT > test {p0=search.aggregation/20_terms/string profiler via global ordinals} FAILED
    java.lang.AssertionError: Failure at [search.aggregation/20_terms:863]: profile.shards.0.aggregations.0.debug.segments_with_multi_valued_ords didn't match expected value:
    profile.shards.0.aggregations.0.debug.segments_with_multi_valued_ords: expected Integer [0] but was Integer [1]
        at __randomizedtesting.SeedInfo.seed([DA2B6434DB8440A7:527F5BEE75782D5F]:0)
        at org.opensearch.test.rest.yaml.OpenSearchClientYamlSuiteTestCase.executeSection(OpenSearchClientYamlSuiteTestCase.java:442)
        at org.opensearch.test.rest.yaml.OpenSearchClientYamlSuiteTestCase.test(OpenSearchClientYamlSuiteTestCase.java:415)
        at jdk.internal.reflect.GeneratedMethodAccessor12.invoke(Unknown Source)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:568)
        at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1750)
        at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:938)
        at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:974)
        at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:988)
        at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
        at org.junit.rules.RunRules.evaluate(RunRules.java:20)
        at org.apache.lucene.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:49)
        at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:45)
        at org.apache.lucene.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:48)
        at org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:64)
        at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:47)
        at org.junit.rules.RunRules.evaluate(RunRules.java:20)
        at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
        at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:368)
        at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:817)
        at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:468)
        at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:947)
        at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:832)
        at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:883)
        at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:894)
        at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:45)
        at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
        at org.apache.lucene.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:41)
        at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
        at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
        at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
        at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
        at org.apache.lucene.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
        at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:47)
        at org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:64)
        at org.apache.lucene.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:54)
        at org.junit.rules.RunRules.evaluate(RunRules.java:20)
        at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
        at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:368)
        at java.base/java.lang.Thread.run(Thread.java:833)

penghuo · 2022-02-17T17:13:27Z

@andrross Can't reproduce the failed test on my branch. Trying now.

dblock · 2022-02-17T17:29:12Z

start gradle check

nknize · 2022-02-17T17:54:58Z

Can't reproduce the failed test on my branch. Trying now.

confirm passing for me as well

nknize

LGTM... happy to merge once gradle check passes. This should unblock the bwc failures on other PRs as well...

opensearch-ci-bot · 2022-02-17T18:15:55Z

✅ Gradle Check success ec9b678
Log 2501

Reports 2501

Adjust main version after backport to 1.x

ec9b678

Signed-off-by: Peng Huo <penghuo@gmail.com>

penghuo requested a review from a team as a code owner February 17, 2022 01:14

andrross mentioned this pull request Feb 17, 2022

Add proxy settings for GCS repository plugin #2096

Merged

5 tasks

nknize mentioned this pull request Feb 17, 2022

[Remove] Default Mapping #2151

Merged

This was referenced Feb 17, 2022

[BUG] :distribution:docker:buildDockerImage failures downloading from http://vault.centos.org #2154

Closed

Revert "Support first and last parameter for missing bucket ordering … #2145

Closed

nknize approved these changes Feb 17, 2022

View reviewed changes

nknize added >test-failure Test failure from CI, local build, etc. backwards-compatibility v2.0.0 Version 2.0.0 labels Feb 17, 2022

andrross merged commit 9ea25c4 into opensearch-project:main Feb 17, 2022

mattweber mentioned this pull request Feb 17, 2022

[BUG] BWC failures for aggregations in MixedClusterClientYamlTestSuiteIT #2143

Closed

This was referenced Feb 18, 2022

[BUG] Flaky Test - search.aggregation/20_terms/string profiler via global ordinals #2176

Closed

Support _first and _last parameter for missing bucket ordering in composite aggregation #1899

Closed

Conversation

penghuo commented Feb 17, 2022

Description

Issues Resolved

Check List

Uh oh!

opensearch-ci-bot commented Feb 17, 2022

Uh oh!

opensearch-ci-bot commented Feb 17, 2022

Uh oh!

andrross commented Feb 17, 2022

Uh oh!

andrross commented Feb 17, 2022

Uh oh!

opensearch-ci-bot commented Feb 17, 2022

Uh oh!

andrross commented Feb 17, 2022

Uh oh!

andrross commented Feb 17, 2022

Uh oh!

mattweber commented Feb 17, 2022

Uh oh!

opensearch-ci-bot commented Feb 17, 2022

Uh oh!

andrross commented Feb 17, 2022

Uh oh!

penghuo commented Feb 17, 2022

Uh oh!

dblock commented Feb 17, 2022

Uh oh!

nknize commented Feb 17, 2022

Uh oh!

nknize left a comment

Choose a reason for hiding this comment

Uh oh!

opensearch-ci-bot commented Feb 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants