[Backport 1.x] Reintroduce negative epoch_millis #1991#2314
Closed
opensearch-trigger-bot[bot] wants to merge 1 commit into
Closed
[Backport 1.x] Reintroduce negative epoch_millis #1991#2314opensearch-trigger-bot[bot] wants to merge 1 commit into
opensearch-trigger-bot[bot] wants to merge 1 commit into
Conversation
* Reintroduce negative epoch_millis #1991 Fixes a regression introduced with Elasticsearch 7 regarding the date field type that removed support for negative timestamps with sub-second granularity. Thanks to Ryan Kophs (https://github.com/rkophs) for allowing me to use his previous work. Signed-off-by: Breno Faria <breno.faria@intrafind.de> * applying spotless fix Signed-off-by: Breno Faria <breno.faria@intrafind.de> * more conservative implementation of isSupportedBy Signed-off-by: Breno Faria <breno.faria@intrafind.de> * adding braces to control flow statement Signed-off-by: Breno Faria <breno.faria@intrafind.de> * spotless fix... Signed-off-by: Breno Faria <breno.faria@intrafind.de> Co-authored-by: Breno Faria <breno.faria@intrafind.de> (cherry picked from commit 4b89410)
Collaborator
|
Can one of the admins verify this patch? |
dblock
approved these changes
Mar 2, 2022
Member
|
@VachaShah What's the guidance for noreply.github.com in DCO? What should @br3no do? |
Contributor
@br3no's email might be private, so the backport workflow would not be able read the email and the DCO app won't be able to read it. dcoapp/app#134 The commit would need to be manually amended with the sign off, or a manual backport :| |
Contributor
|
I have changed my email settings. |
Member
|
@br3no Could you please manually backport this one? |
Contributor
Contributor
Contributor
|
Okay, so let me see if I get the workflow right:
Is this correct? @VachaShah @dblock |
Member
Yep! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 4b89410 from #2232