Deprecate setting 'cluster.service.slow_master_task_logging_threshold' and introduce the alternative setting 'cluster.service.slow_cluster_manager_task_logging_threshold'#2451
Merged
tlfeng merged 3 commits intoopensearch-project:mainfrom Mar 18, 2022
Conversation
Closed
12 tasks
Collaborator
|
Can one of the admins verify this patch? |
Signed-off-by: Tianli Feng <ftianli@amazon.com>
tlfeng
force-pushed
the
setting-slow_cluster_manager
branch
from
9a29930 to
49ad9bf
Compare
Collaborator
|
❌ Gradle Check failure 9a2993040c05735d4f0e3e9dc54f487695fcaee3 |
tlfeng
added
enhancement
kartg
reviewed
Mar 15, 2022
server/src/test/java/org/opensearch/cluster/service/MasterServiceRenamedSettingTests.java
Outdated
Show resolved
Hide resolved
added 2 commits
March 15, 2022 21:32
…r_manager Signed-off-by: Tianli Feng <ftianli@amazon.com>
…alue Signed-off-by: Tianli Feng <ftianli@amazon.com>
kartg
approved these changes
Mar 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
cluster.service.slow_cluster_manager_task_logging_threshold, aims to replace the existingcluster.service.slow_master_task_logging_thresholdcluster.service.slow_master_task_logging_thresholdas the fallback to the new settingcluster.service.slow_master_task_logging_thresholdReference: commit 63c75d1 / PR #2221
Issues Resolved
Part of #1549
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.