Remove endpoint_suffix dependency on account key

[raphlopez]

Signed-off-by: Raphael Lopez raphael.lopez@aiven.io

Description

Previously, the repository-azure plugin failed to load when a SAS token was provided for authentication rather than an Azure Storage Account key. This was due to a dependency in the ENDPOINT_SUFFIX_SETTING - more details in the issue description.

I opted to remove the dependency altogether since the plugin has a check in buildConnectString() to ensure that either a SAS token or a Storage Account key is provided.

Issues Resolved

Relates to #2462

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[opensearch-ci-bot]

❌   Gradle Check failure 5e87223
Log 3443

Reports 3443

[nknize]

Another flake documented in #1703; refiring

REPRODUCE WITH: ./gradlew ':qa:remote-clusters:integTest' --tests "org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks" -Dtests.seed=5F38717E6653A507 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=es-BO -Dtests.timezone=America/Chicago -Druntime.java=17

org.opensearch.cluster.remote.test.RemoteClustersIT > testHAProxyModeConnectionWorks FAILED
    java.lang.AssertionError
        at __randomizedtesting.SeedInfo.seed([5F38717E6653A507:584EA4B55DD5D35A]:0)
        at org.junit.Assert.fail(Assert.java:87)
        at org.junit.Assert.assertTrue(Assert.java:42)
        at org.junit.Assert.assertTrue(Assert.java:53)
        at org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks(RemoteClustersIT.java:125)

[nknize]

start gradle check

[nknize]

LGTM. Thx!

[opensearch-ci-bot]

❌   Gradle Check failure 5e87223
Log 3595

Reports 3595

[dblock]

start gradle check

[opensearch-ci-bot]

❌   Gradle Check failure 5e87223
Log 3622

Reports 3622

[tlfeng]

3622 is issue #1703
start gradle check

[opensearch-ci-bot]

✅   Gradle Check success 5e87223
Log 4065

Reports 4065

[tlfeng]

Thank you for providing the solution! Just double check, will this code change resolves issue #2462?

[raphlopez]

My pleasure! And yes, #2462 will be resolved once this is merged.