Revert "Make High-Level-Rest-Client tests allow deprecation warning temporarily (#2702)"

[tlfeng]

Description

This reverts commit 6a2a33d.

The PR can be merged when all the other PRs in #2511 is merged, especially PR #2683 [<- archived]

During the process of deprecating REST API request parameter master_timeout and adding alternative parameter cluster_manager_timeout, I made High-Level-Rest-Client tests allow deprecation warning temporarily, by changing the argument of setStrictDeprecationMode() to false when building RestClient for tests, in the above commit / PR #2702,

This PR sets the High-Level-Rest-Client tests back to treating warning header as a failure.

Issues Resolved

The last step to resolve #2511.

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[opensearch-ci-bot]

✅   Gradle Check success 96d77efdece83b6c71bdef87d8b11b611ddaf30c
Log 4133

Reports 4133

[tlfeng]

Tests with failures:
 - org.opensearch.backwards.ExceptionIT.testOpensearchException
 - org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=tasks.list/10_basic/tasks_list test}

REPRODUCE WITH: ./gradlew ':qa:mixed-cluster:v2.0.0#mixedClusterTest' --tests "org.opensearch.backwards.ExceptionIT.testOpensearchException" -Dtests.seed=D5F130EEE0745C2A -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=ru-RU -Dtests.timezone=CNT -Druntime.java=17

org.opensearch.backwards.ExceptionIT > testOpensearchException FAILED
    org.opensearch.client.WarningFailureException: method [GET], host [http://127.0.0.1:33867], URI [_cat/master?h=id], status line [HTTP/1.1 200 OK]
    Warnings: [[GET /_cat/master] is deprecated! Use [GET /_cat/cluster_manager] instead.]
    TDvNsrtlRN-XVfX6m5x5Dw
        at __randomizedtesting.SeedInfo.seed([D5F130EEE0745C2A:7A08F576466769D0]:0)
        at app//org.opensearch.client.RestClient.convertResponse(RestClient.java:346)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:320)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:295)
        at app//org.opensearch.backwards.ExceptionIT.logClusterNodes(ExceptionIT.java:50)
        at app//org.opensearch.backwards.ExceptionIT.testOpensearchException(ExceptionIT.java:28)

The above is tracked in issue #2759

REPRODUCE WITH: ./gradlew ':qa:mixed-cluster:v2.0.0#mixedClusterTest' --tests "org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT" -Dtests.method="test {p0=tasks.list/10_basic/tasks_list test}" -Dtests.seed=D5F130EEE0745C2A -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=sk-SK -Dtests.timezone=MET -Druntime.java=17

org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT > test {p0=tasks.list/10_basic/tasks_list test} FAILED
    java.lang.AssertionError: Failure at [tasks.list/10_basic:15]: field [nodes.$node_id.roles] doesn't have a true value
    Expected: not null
         but: was null
        at __randomizedtesting.SeedInfo.seed([D5F130EEE0745C2A:5DA50F344E8831D2]:0)
        at org.opensearch.test.rest.yaml.OpenSearchClientYamlSuiteTestCase.executeSection(OpenSearchClientYamlSuiteTestCase.java:454)

The above is tacked in issue #2757

[opensearch-ci-bot]

✅   Gradle Check success 5b32adc
Log 4135

Reports 4135

[mch2]

added blocked on #2511

[opensearch-ci-bot]

✅   Gradle Check success 4d63ee9
Log 4626

Reports 4626

[tlfeng]

Thanks @reta and @kartg ! 👍