Skip to content

Change deprecation message for REST API parameter 'master_timeout' to specify the version of removal#2863

Merged
tlfeng merged 2 commits into
opensearch-project:mainfrom
tlfeng:change-deprecation-message-master-timeout
Apr 11, 2022
Merged

Change deprecation message for REST API parameter 'master_timeout' to specify the version of removal#2863
tlfeng merged 2 commits into
opensearch-project:mainfrom
tlfeng:change-deprecation-message-master-timeout

Conversation

@tlfeng
Copy link
Copy Markdown
Contributor

@tlfeng tlfeng commented Apr 11, 2022 •
edited
Loading

Description

According to the comments, change the deprecation message of REST API parameter master_timeout:
#2678 (comment)
#2682 (comment)

  • Specify the version (3.0) to remove the deprecated parameter.
  • Change the word promote to support.

Issues Resolved

Related to #2511

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Tianli Feng added 2 commits April 11, 2022 14:58
Change deprecation message for API parameter master_timeout to specif…
9d7e6ae 
…y the version of removal

Signed-off-by: Tianli Feng <ftianli@amazon.com>
Change deprecation message for API parameter master_timeout in rest a…
90a4273 
…pi yaml test

Signed-off-by: Tianli Feng <ftianli@amazon.com>
@tlfeng tlfeng requested a review from a team as a code owner April 11, 2022 22:04
@tlfeng tlfeng added v2.0.0 Version 2.0.0 deprecate backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch v3.0.0 Issues and PRs related to version 3.0.0 and removed v3.0.0 Issues and PRs related to version 3.0.0 labels Apr 11, 2022
@tlfeng tlfeng mentioned this pull request Apr 11, 2022
Merged
5 tasks
@opensearch-ci-bot
Copy link
Copy Markdown
Collaborator

opensearch-ci-bot commented Apr 11, 2022

✅   Gradle Check success 90a4273
Log 4383

Reports 4383

@tlfeng tlfeng merged commit ba8657a into opensearch-project:main Apr 11, 2022
@tlfeng tlfeng deleted the change-deprecation-message-master-timeout branch April 11, 2022 22:59
opensearch-trigger-bot Bot pushed a commit that referenced this pull request Apr 11, 2022
@github-actions
Change deprecation message for REST API parameter 'master_timeout' to…
b03941e 
… specify the version of removal (#2863)

Signed-off-by: Tianli Feng <ftianli@amazon.com>
(cherry picked from commit ba8657a)
@opensearch-trigger-bot opensearch-trigger-bot Bot mentioned this pull request Apr 11, 2022
Merged
opensearch-trigger-bot Bot pushed a commit that referenced this pull request Apr 11, 2022
@github-actions
Change deprecation message for REST API parameter 'master_timeout' to…
2d24bf6 
… specify the version of removal (#2863)

Signed-off-by: Tianli Feng <ftianli@amazon.com>
(cherry picked from commit ba8657a)
@opensearch-trigger-bot opensearch-trigger-bot Bot mentioned this pull request Apr 11, 2022
Merged
tlfeng pushed a commit that referenced this pull request Apr 12, 2022
@opensearch-trigger-bot
Change deprecation message for REST API parameter 'master_timeout' to…
b4a3517 
… specify the version of removal (#2863) (#2864)

Signed-off-by: Tianli Feng <ftianli@amazon.com>
(cherry picked from commit ba8657a)
tlfeng pushed a commit that referenced this pull request Apr 12, 2022
@opensearch-trigger-bot
Change deprecation message for REST API parameter 'master_timeout' to…
3e78a04 
… specify the version of removal (#2863) (#2865)

Signed-off-by: Tianli Feng <ftianli@amazon.com>
(cherry picked from commit ba8657a)
@tlfeng tlfeng mentioned this pull request Apr 12, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@anasalkouz anasalkouz anasalkouz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch deprecate v2.0.0 Version 2.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tlfeng @opensearch-ci-bot @anasalkouz