Skip to content

Remove JavaVersion, use builtin Runtime.Version to deal with runtime versions#3006

Merged
dblock merged 1 commit intoopensearch-project:mainfrom
reta:issue-3003
Apr 20, 2022
Merged

Remove JavaVersion, use builtin Runtime.Version to deal with runtime versions#3006
dblock merged 1 commit intoopensearch-project:mainfrom
reta:issue-3003

Conversation

@reta
Copy link
Copy Markdown
Contributor

@reta reta commented Apr 20, 2022 •
edited
Loading

Signed-off-by: Andriy Redko andriy.redko@aiven.io

Description

Since JDK-9, the JDK provide standard means to manipulate runtime version using Runtime and Runtime.Version. It makes sense to remove JavaVersion in favour of standard Runtime.Version.

Also, since 2.0 sets JDK-11 as baseline, we could drop all checks for JDK-8/9/10

Issues Resolved

Closes #3003

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta
Remove JavaVersion, use builtin Runtime.Version to deal with runtime …
caadb4d 
…versions

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@reta reta requested a review from a team as a code owner April 20, 2022 19:17
@opensearch-ci-bot
Copy link
Copy Markdown
Collaborator

opensearch-ci-bot commented Apr 20, 2022

✅   Gradle Check success caadb4d
Log 4648

Reports 4648

dblock
dblock approved these changes Apr 20, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice and easy

@dblock dblock merged commit 3b7e654 into opensearch-project:main Apr 20, 2022
@dblock dblock added the backport 2.x Backport to 2.x branch label Apr 20, 2022
@dblock
Copy link
Copy Markdown
Member

dblock commented Apr 20, 2022

Labelled to backport to 2.x but not 2.0. LMK if you feel otherwise.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 20, 2022
@reta @github-actions
Remove JavaVersion, use builtin Runtime.Version to deal with runtime …
23de277 
…versions (#3006)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 3b7e654)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 20, 2022
Merged
@reta
Copy link
Copy Markdown
Contributor Author

reta commented Apr 20, 2022

Labelled to backport to 2.x but not 2.0. LMK if you feel otherwise.

Thanks @dblock ! I think @nknize is reluctant to make any changes in 2.0 before release, or this one could go?

dblock pushed a commit that referenced this pull request Apr 20, 2022
@opensearch-trigger-bot @reta
Remove JavaVersion, use builtin Runtime.Version to deal with runtime …
4422540 
…versions (#3006) (#3013)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 3b7e654)

Co-authored-by: Andriy Redko <andriy.redko@aiven.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dblock dblock dblock approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport 2.x Backport to 2.x branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove JavaVersion in favour of standard Runtime.Version

3 participants

@reta @opensearch-ci-bot @dblock