[2.0] Replace 'master' terminology with 'cluster manager' in log messages in 'server/src/main' directory - Part 2#3174
Conversation
…messages Signed-off-by: Tianli Feng <ftianli@amazon.com>
tlfeng
changed the title
tlfeng
changed the title
| @@ -208,7 +208,7 @@ public void testTwoNodesNoMasterBlock() throws Exception { | |||
| otherNode = node1Name.equals(masterNode) ? node2Name : node1Name; | |||
| logger.info("--> add voting config exclusion for master node, to be sure it's not elected"); | |||
There was a problem hiding this comment.
There are still a few master references on L#209, L#158, L#173
There was a problem hiding this comment.
Thank you for your careful review!
Ah, I didn't realized there are still lots of log messages contain master in server/src/internalClusterTest directory and is shown in this PR. 😂
It definitely doesn't look good. Thanks for pointing out!
To minimize the change for 2.0 version, I propose to limit the scope of this PR to server/src/main directory. For the master references in other directories, I will create PR to main branch first and then backport to 2.x branch.
So I will revert those changes in server/src/internalClusterTest directory. Is that fine?
There was a problem hiding this comment.
The code changes for this PR is actually a subset of #2519. I didn't plan to backport that PR to 2.0 branch since the feature for 2.0 version is frozen and I want to reduce the code change, but when I saw there are still log messages contain master terminology, I think it's worth to replace all master reference in log message in 2.0 version for consistency.
I will make sure all the log message in server/src/main don't have master terminology, since it will be exposed to the user.
For the master terminology in other directories, I will handle in different PRs ( tracked in issue #1548)
Signed-off-by: Tianli Feng <ftianli@amazon.com>
tlfeng
changed the title
4 participants
Description
In PR #2575, most of the
masterterminology in log messages is replaced bycluster-manager, but there are a few remaining.This PR replaces more
masterword withcluster-managerinserver/src/maindirectory that used in log messages.Issues Resolved
#2539
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.