Replace 'master' terminology with 'cluster manager' in 'modules' directory#3328
Merged
dblock merged 3 commits intoopensearch-project:mainfrom May 16, 2022
Merged
Conversation
Signed-off-by: Tianli Feng <ftianli@amazon.com>
Signed-off-by: Tianli Feng <ftianli@amazon.com>
Closed
12 tasks
tlfeng
added
v2.1.0
Signed-off-by: Tianli Feng <ftianli@amazon.com>
dblock
approved these changes
May 16, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 16, 2022
…ctory (#3328) * Replace 'master' terminology with 'cluster manager' in modules directory Signed-off-by: Tianli Feng <ftianli@amazon.com> * Replace 'master' with 'cluster_manager' in yaml rest test files Signed-off-by: Tianli Feng <ftianli@amazon.com> * Replace master_node with cluster_manager_node in cluster.state API test Signed-off-by: Tianli Feng <ftianli@amazon.com> (cherry picked from commit 5a02949)
dblock
pushed a commit
that referenced
this pull request
May 16, 2022
…ctory (#3328) (#3333) * Replace 'master' terminology with 'cluster manager' in modules directory Signed-off-by: Tianli Feng <ftianli@amazon.com> * Replace 'master' with 'cluster_manager' in yaml rest test files Signed-off-by: Tianli Feng <ftianli@amazon.com> * Replace master_node with cluster_manager_node in cluster.state API test Signed-off-by: Tianli Feng <ftianli@amazon.com> (cherry picked from commit 5a02949) Co-authored-by: Tianli Feng <ftianli@amazon.com>
Contributor
Author
|
@dblock Thank you so much for reviewing my PRs of replacing the "master" terminology! 🏅👍💐 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
modulesdirectory.Replacement rules:
master->cluster_managerorclusterManager(variable name) orcluster-manager(code comment)Master->ClusterManagerIssues Resolved
A part of #1548
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.