Skip to content

Replace 'master' terminology with 'cluster manager' in 'plugins' directory#3329

Merged
dblock merged 2 commits intoopensearch-project:mainfrom
tlfeng:replace-master-int-plugins
May 16, 2022
Merged

Replace 'master' terminology with 'cluster manager' in 'plugins' directory#3329
dblock merged 2 commits intoopensearch-project:mainfrom
tlfeng:replace-master-int-plugins

Conversation

@tlfeng
Copy link
Copy Markdown
Contributor

@tlfeng tlfeng commented May 15, 2022

Description

  • Replace the non-inclusive terminology "master" with "cluster manager" in code comments, internal variable and method names, in plugins directory.
  • Backwards compatibility is not impacted.

Replacement rules:

  • master -> cluster_manager or clusterManager (variable name) or cluster-manager (code comment)
  • Master -> ClusterManager

Issues Resolved

A part of #1548

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ctory

Signed-off-by: Tianli Feng <ftianli@amazon.com>
@tlfeng tlfeng requested review from a team and reta as code owners May 15, 2022 22:29
@tlfeng tlfeng added v2.1.0 Issues and PRs related to version 2.1.0 backport 2.x Backport to 2.x branch labels May 15, 2022
@opensearch-ci-bot
Copy link
Copy Markdown
Collaborator

✅   Gradle Check success d0f621b
Log 5349

Reports 5349

Signed-off-by: Tianli Feng <ftianli@amazon.com>
@opensearch-ci-bot
Copy link
Copy Markdown
Collaborator

❌   Gradle Check failure 2ea0e94
Log 5354

Reports 5354

@tlfeng
Copy link
Copy Markdown
Contributor Author

tlfeng commented May 16, 2022

re-run: start gradle check

@opensearch-ci-bot
Copy link
Copy Markdown
Collaborator

❌   Gradle Check failure 2ea0e94
Log 5357

Reports 5357

@tlfeng
Copy link
Copy Markdown
Contributor Author

tlfeng commented May 16, 2022

re-run: start gradle check

@opensearch-ci-bot
Copy link
Copy Markdown
Collaborator

✅   Gradle Check success 2ea0e94
Log 5358

Reports 5358

@dblock dblock merged commit 8460bcf into opensearch-project:main May 16, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 16, 2022
…ctory (#3329)

* Replace 'master' terminology with 'cluster manager' in 'plugins' directory

Signed-off-by: Tianli Feng <ftianli@amazon.com>

* Replace master_node with cluster_manager_node in cluster.state API test

Signed-off-by: Tianli Feng <ftianli@amazon.com>
(cherry picked from commit 8460bcf)
dblock pushed a commit that referenced this pull request May 16, 2022
…ctory (#3329) (#3334)

* Replace 'master' terminology with 'cluster manager' in 'plugins' directory

Signed-off-by: Tianli Feng <ftianli@amazon.com>

* Replace master_node with cluster_manager_node in cluster.state API test

Signed-off-by: Tianli Feng <ftianli@amazon.com>
(cherry picked from commit 8460bcf)

Co-authored-by: Tianli Feng <ftianli@amazon.com>
@tlfeng tlfeng deleted the replace-master-int-plugins branch May 16, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.x Backport to 2.x branch v2.1.0 Issues and PRs related to version 2.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants