Add label checks for PRs#3618
Conversation
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
| steps: | ||
| - uses: docker://agilepathway/pull-request-label-checker:latest | ||
| with: | ||
| one_of: bug,documentation,enhancement,feature,security,:test,>upgrade |
There was a problem hiding this comment.
With assumption that automation script will use buckets to layout release notes. For e.g. a PR labeled bug will be placed in [Bug Fixes] section. What should happen when a PR fall into multiple buckets e.g. A bug in security area.
How do we plan to lay out the release notes in this scenario ? Do we need to restrict only one label. If not, how do prioritize bucket for the PR
There was a problem hiding this comment.
That's a good point. With the current mechanisms, we do it manually but have to sift through the PRs to understand where it belongs. This will help to simplify in the sense that it narrows down where the PR belongs and provides a heuristic to help classify. For an automated approach, we can design the solution in a way to account for the priority and we always can manually intervene if needed for a few of the changes.
There was a problem hiding this comment.
Thanks for this change. This is a good starting point towards release notes automation.
Automation related discussion can be done on automation related PRs. Please address @tlfeng comment below.
| steps: | ||
| - uses: docker://agilepathway/pull-request-label-checker:latest | ||
| with: | ||
| one_of: bug,documentation,enhancement,feature,security,:test,>upgrade |
There was a problem hiding this comment.
My concern is the labels in the list may not enough. For example, the PRs created by dependabot, they will be labeled as dependencies automatically. Looks like if not having that label, those PRs will fail the check.
There was a problem hiding this comment.
Thanks for raising the point. I know this is not a complete list and would like inputs on what else can be included. It helps break the PRs atleast into major topics that we currently track. We can always add additional and follow a mapping mechanism in the solution we develop further - i.e. documentation, javadocs -> Documentation
nknize
left a comment
nknize
left a comment
There was a problem hiding this comment.
Ping.. looks like little activity for the last two weeks. Is this ready or is it needing more polish?
|
Closing this in favor #4085 |
5 participants
Signed-off-by: Kunal Kotwani kkotwani@amazon.com
Description
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.