Skip to content

[Backport 2.x] Deprecate public methods and variables that contain 'master' terminology in class 'NoMasterBlockService' and 'MasterService'#4038

Merged
tlfeng merged 1 commit into2.xfrom
backport/backport-4006-to-2.x
Jul 28, 2022
Merged

[Backport 2.x] Deprecate public methods and variables that contain 'master' terminology in class 'NoMasterBlockService' and 'MasterService'#4038
tlfeng merged 1 commit into2.xfrom
backport/backport-4006-to-2.x

Conversation

@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

Backport e65aaca from #4006

…ogy in class 'NoMasterBlockService' and 'MasterService' (#4006)

Deprecates public methods and variables that contain 'master' terminology
in class NoMasterBlockService and MasterService. Unit tests are also
added to ensure consistency with the new naming.

Signed-off-by: Tianli Feng <ftianli@amazon.com>
(cherry picked from commit e65aaca)
@opensearch-trigger-bot opensearch-trigger-bot bot requested review from a team and reta as code owners July 28, 2022 19:37
@github-actions
Copy link
Copy Markdown
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 28, 2022

Codecov Report

❌ Patch coverage is 78.12500% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.59%. Comparing base (5d1dc07) to head (4528ddb).
⚠️ Report is 2803 commits behind head on 2.x.

Files with missing lines Patch % Lines
.../org/opensearch/cluster/service/MasterService.java 62.50% 2 Missing and 1 partial ⚠️
...g/opensearch/cluster/coordination/Coordinator.java 50.00% 0 Missing and 2 partials ⚠️
...org/opensearch/cluster/service/ClusterService.java 0.00% 1 Missing ⚠️
.../opensearch/common/util/concurrent/BaseFuture.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #4038      +/-   ##
============================================
+ Coverage     70.37%   70.59%   +0.22%     
- Complexity    56347    56449     +102     
============================================
  Files          4529     4529              
  Lines        271885   271894       +9     
  Branches      39989    39990       +1     
============================================
+ Hits         191328   191935     +607     
+ Misses        64453    63819     -634     
- Partials      16104    16140      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tlfeng tlfeng added enhancement Enhancement or improvement to existing feature or request backport PRs or issues specific to backporting features or enhancments deprecate v2.2.0 labels Jul 28, 2022
@tlfeng tlfeng merged commit 1d68b52 into 2.x Jul 28, 2022
@tlfeng tlfeng deleted the backport/backport-4006-to-2.x branch July 28, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport PRs or issues specific to backporting features or enhancments deprecate enhancement Enhancement or improvement to existing feature or request v2.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants