Rename Class ending with Plugin to Module under modules dir

[rockybean]

Description

Rename Class Name ending with Plugin to Module under modules dir for better classification with plugins which is not installed by default.

Issues Resolved

#4034

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/1100/
• CommitID: 104d9eb62582262fefb9547ad9e4ca6a86d3c7f8

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/1101/
• CommitID: 52de8eb1414a35c5dd79ccf7566179efac4faa6c

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/1103/
• CommitID: 631e764af1d57b23f39b18ac186c29769827f05c

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/1105/
• CommitID: 603b53a

[nknize]

Thank you so much for your first contribution @rockybean 🎉!!! This is a great moment to have more folks like you willing to step up and help grow the project.

Since there is still some discussion on the best way to draw a logical API distinction between modules and plugins w/o introducing more confusion I'm going to hold on an official approval until we settle on a path forward. Let's continue to discuss on the issue and we'll circle back here on the implementation.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/1142/
• CommitID: a595164e10587ab1aee4901273cc0fd5b3a18b0d

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/1143/
• CommitID: f2549f6

[rockybean]

Is there any way to trigger Gradle Check task again?
I rerun the failure task on my local env but all is ok. So I suppose a rerun can fix this check failure.
Anybody can help here? thanks

@nknize

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/1147/
• CommitID: f2549f6

[codecov-commenter]

Codecov Report

Merging #4042 (f2549f6) into main (e65aaca) will increase coverage by 0.18%.
The diff coverage is 69.56%.

@@             Coverage Diff              @@
##               main    #4042      +/-   ##
============================================
+ Coverage     70.57%   70.75%   +0.18%     
- Complexity    56845    56959     +114     
============================================
  Files          4581     4581              
  Lines        273842   273842              
  Branches      40148    40148              
============================================
+ Hits         193275   193768     +493     
+ Misses        64237    63765     -472     
+ Partials      16330    16309      -21     

Impacted Files	Coverage Δ
.../main/java/org/opensearch/geo/GeoModulePlugin.java	0.00% <0.00%> (ø)
...search/ingest/common/IngestCommonModulePlugin.java	9.52% <0.00%> (ø)
...va/org/opensearch/ingest/geoip/GeoIpProcessor.java	87.34% <ø> (ø)
...ensearch/ingest/geoip/IngestGeoIpModulePlugin.java	65.33% <0.00%> (ø)
...arch/script/expression/ExpressionModulePlugin.java	0.00% <0.00%> (ø)
...ensearch/script/mustache/MustacheModulePlugin.java	0.00% <0.00%> (ø)
...ugin/repository/url/URLRepositoryModulePlugin.java	0.00% <0.00%> (ø)
.../ingest/useragent/IngestUserAgentModulePlugin.java	51.85% <50.00%> (ø)
...egations/matrix/MatrixAggregationModulePlugin.java	100.00% <100.00%> (ø)
...ch/analysis/common/CommonAnalysisModulePlugin.java	90.34% <100.00%> (ø)
... and 487 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

[nknize]

Excellent! Thank you for taking care of this @rockybean

[rockybean]

Close #4034

[dblock]

Why did we go with ModulePlugin vs Module?

[reta]

@dblock check please #4034 (comment)