Skip to content

Rename classes with name 'MasterService' to 'ClusterManagerService' in directory 'test/framework'#4051

Merged
tlfeng merged 3 commits intoopensearch-project:mainfrom
tlfeng:rename-masterservice-test-framework
Aug 1, 2022
Merged

Rename classes with name 'MasterService' to 'ClusterManagerService' in directory 'test/framework'#4051
tlfeng merged 3 commits intoopensearch-project:mainfrom
tlfeng:rename-masterservice-test-framework

Conversation

@tlfeng
Copy link
Copy Markdown
Contributor

@tlfeng tlfeng commented Jul 30, 2022

Description

To support inclusive language, the master terminology is going to be replaced by cluster manager in the code base.

After the class MasterService has been deprecated and class ClusterManagerService has been created in #4022 / commit 740f75d, the classes in test/framework directory with name 'MasterService' can be deprecated and renamed.

  • Rename the following classes in test/framework directory:
FakeThreadPoolMasterService -> FakeThreadPoolClusterManagerService
BlockMasterServiceOnMaster -> BlockClusterManagerServiceOnClusterManager
BusyMasterServiceDisruption -> BusyClusterManagerServiceDisruption

In the following PR (#4058), I will add back the above 3 classes with the old name and deprecate them, to keep the backwards compatibility.

Issues Resolved

A part of issue #3543

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.x Backport to 2.x branch enhancement Enhancement or improvement to existing feature or request v2.2.0 v3.0.0 Issues and PRs related to version 3.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants